Page MenuHomeFreeBSD

bsdinstall: use gpt/efiboot0 label in /etc/fstab
ClosedPublic

Authored by asomers on May 24 2022, 6:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 7, 11:49 PM
Unknown Object (File)
Feb 8 2024, 10:23 AM
Unknown Object (File)
Jan 15 2024, 1:56 PM
Unknown Object (File)
Dec 23 2023, 9:51 AM
Unknown Object (File)
Dec 2 2023, 5:43 PM
Unknown Object (File)
Nov 18 2023, 2:51 PM
Unknown Object (File)
Nov 18 2023, 2:49 PM
Unknown Object (File)
Nov 18 2023, 2:09 PM
Subscribers

Details

Summary

Otherwise, boot will hang if the numbering of disks has changed since
initial install.

MFC after: 2 weeks
Sponsored by: Axcient

Test Plan

Ran bsdinstall in a VM

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Thanks for this, I ran into it awhile back and didn't have time to run it down!

This revision is now accepted and ready to land.May 24 2022, 7:01 PM

So long as we don't have two disks with that label, we'll be fine...
So this is better than what we had, but not quite to where we need to get to....
Though the functionality we need to get there isn't in bsdinstall...

In D35309#800308, @imp wrote:

So long as we don't have two disks with that label, we'll be fine...
So this is better than what we had, but not quite to where we need to get to....
Though the functionality we need to get there isn't in bsdinstall...

Well, when using a mirrored setup at least bsdinstall creates a /dev/gpt/efiboot0 and a /dev/gpt/efiboot1. What functionality do you think we need?

In D35309#800308, @imp wrote:

So long as we don't have two disks with that label, we'll be fine...
So this is better than what we had, but not quite to where we need to get to....
Though the functionality we need to get there isn't in bsdinstall...

Well, when using a mirrored setup at least bsdinstall creates a /dev/gpt/efiboot0 and a /dev/gpt/efiboot1. What functionality do you think we need?

We should use the ESP we booted from with /dev/efi/esp.... which is a set of patches that aren't even half-assed yet in my tree...