Page MenuHomeFreeBSD
Differential D35308

comms/qsstv: fix build with graphics/openjpeg 2.5 by removing unnecessary patches
ClosedPublic
Actions

Authored by vishwin on May 24 2022, 4:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 23, 8:14 AM
Unknown Object (File)
Mon, Oct 20, 11:36 PM
Unknown Object (File)
Mon, Oct 20, 11:36 PM
Unknown Object (File)
Mon, Oct 20, 11:36 PM
Unknown Object (File)
Mon, Oct 20, 11:36 PM
Unknown Object (File)
Mon, Oct 20, 1:34 PM
Unknown Object (File)
Sun, Oct 12, 12:11 PM
Unknown Object (File)
Thu, Oct 9, 1:18 AM
View All Files
Subscribers
mat

Details

Reviewers
tcberner
fluffy
arrowd
Commits
R11:698607cd81cc: comms/qsstv: fix build with graphics/openjpeg 2.5 by removing unnecessary…
R11:543d8888c956: comms/qsstv: fix build with graphics/openjpeg 2.5 by removing unnecessary…
Summary

While here, have ourselves a working DEBUG build

Test Plan

Works as intended, minus encoding/saving JPEG2000 (crashes). Not sure if it has ever worked.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 45692
Build 42580: arc lint + arc unit

Event Timeline

vishwin created this revision.May 24 2022, 4:34 PM
Herald added a subscriber: mat. · View Herald TranscriptMay 24 2022, 4:34 PM
vishwin requested review of this revision.May 24 2022, 4:34 PM
Harbormaster completed remote builds in B45692: Diff 106322.May 24 2022, 4:35 PM
arrowd added inline comments.May 24 2022, 4:58 PM
comms/qsstv/Makefile
34

Why does debug build require doxygen?

arrowd added inline comments.May 24 2022, 5:00 PM
comms/qsstv/files/patch-config_directoriesconfig.cpp
1

Whitespace change, do not include it in the commit.

comms/qsstv/files/patch-drmrx_demodulator.cpp
3

If this patch applies without adjusting @@ lines @@, restore this change.

comms/qsstv/files/patch-rig_rigcontrol.cpp
3

Same comment as for patch-drmrx_demodulator.cpp.

vishwin added inline comments.May 24 2022, 5:01 PM
comms/qsstv/Makefile
34

Probably for QtCreator, even though dox doesn't install anything here: http://users.telenet.be/on4qz/qsstv/manual/installation.html

vishwin updated this revision to Diff 106323.May 24 2022, 5:11 PM

remove unnecessary metadata changes (even though makepatch will regenerate them again)

Harbormaster completed remote builds in B45693: Diff 106323.May 24 2022, 5:11 PM
arrowd accepted this revision.May 24 2022, 5:20 PM
This revision is now accepted and ready to land.May 24 2022, 5:20 PM
Closed by commit R11:543d8888c956: comms/qsstv: fix build with graphics/openjpeg 2.5 by removing unnecessary… (authored by vishwin). · Explain WhyMay 24 2022, 5:36 PM
This revision was automatically updated to reflect the committed changes.
vishwin added a commit: R11:543d8888c956: comms/qsstv: fix build with graphics/openjpeg 2.5 by removing unnecessary….
vishwin added a commit: R11:698607cd81cc: comms/qsstv: fix build with graphics/openjpeg 2.5 by removing unnecessary….

Revision Contents
Changeset List

Diff 106322

View Options

comms/qsstv/Makefile

Loading...
View Options

comms/qsstv/files/patch-config_directoriesconfig.cpp

Loading...
View Options

comms/qsstv/files/patch-drmrx_demodulator.cpp

Loading...
View Options

comms/qsstv/files/patch-qsstv.pro

Loading...
View Options

comms/qsstv/files/patch-rig_rigcontrol.cpp

Loading...
View Options

comms/qsstv/files/patch-utils_color.cpp

Loading...
View Options

comms/qsstv/files/patch-utils_jp2io.h

Loading...
View Options

comms/qsstv/pkg-plist

Loading...