boot/zfs: Extend zfsimpl.h and make it easier to use
ClosedPublic
Actions

Authored by markj on May 20 2022, 11:17 PM.

Details

Reviewers

Commits

rG77649f35a7e5: boot/zfs: Extend zfsimpl.h and make it easier to use

Summary

Some makefs(8) patches make use of zfsimpl.h (not zfsimpl.c though) to
provide definitions for various on-disk structure. Most of this diff
simply adds new definitions that are useful.

Also reduce dependencies of the header:

remove an unused list_node_t field to drop the sys/list.h dependency
replace CTASSERT with _Static_assert

And fix the declaration of decode_embedded_bp_compressed().

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.May 20 2022, 11:17 PM

Herald added subscribers: delphij, imp. · View Herald TranscriptMay 20 2022, 11:17 PM

markj requested review of this revision.May 20 2022, 11:17 PM

Harbormaster completed remote builds in B45656: Diff 106232.May 20 2022, 11:17 PM

tsoome added inline comments.May 21 2022, 6:41 AM

sys/cddl/boot/zfs/zfsimpl.h
560–561	Could use some verbose message here:)
1913–1914	we are actually not using this structure at all, I think we can just drop it from here.
2062	extern maybe?