ping: if -S srcaddr uses a numeric address, use that protocol
ClosedPublic
Actions

Authored by karels on May 20 2022, 2:17 PM.

Details

Reviewers

Commits

rGe23a0f521f68: ping: if -S srcaddr uses a numeric address, use that protocol
rG5af718a5927a: ping: if -S srcaddr uses a numeric address, use that protocol

Summary

The command "ping -S dotted.quad hostname" fails on dual-stack hosts
with the confusing message "ping: invalid source address: Name does
not resolve" because IPv6 is selected in preference. If the argument
to -S is numeric (likely), select the corresponding address family,
as if -4 or -6 was specified.

Test Plan

tested manually

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

karels created this revision.May 20 2022, 2:17 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 20 2022, 2:17 PM

karels requested review of this revision.May 20 2022, 2:17 PM

Harbormaster completed remote builds in B45647: Diff 106206.May 20 2022, 2:17 PM

Good catch. Do you think you could add a testcase to sbin/ping/tests/ping_test.sh ?

I haven't used atf. I can guess at much of the layout, but don't know how to run it. Is there documentation somewhere?

In D35271#799385, @karels wrote:

I haven't used atf. I can guess at much of the layout, but don't know how to run it. Is there documentation somewhere?

The atf-sh-api(3) man page is the best place to look.

Add ATF tests.

Harbormaster completed remote builds in B45653: Diff 106229.May 20 2022, 10:34 PM

asomers added inline comments.May 20 2022, 10:41 PM