Page MenuHomeFreeBSD

bsdinstall(8) services: Set moused_nondefault_enable
Needs ReviewPublic

Authored by asiciliano on Fri, May 13, 11:21 AM.

Details

Reviewers
bapt
bcran
Summary

PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227999
Reported by @bcran :

bsdinstall(8) has an option to enable moused support. However, if it's _not_ selected, moused is still started through the configuration of nondefault devices. It might be nice to either have another option to disable nondefault devices, or have bsdinstall automatically add the moused_nondefault_enable="NO" setting to rc.conf unless moused support is selected.

@bcran I added "automatically add the moused_nondefault_enable="NO" setting to rc.conf unless moused support is selected", or do you prefer "another option to disable nondefault devices"? If you want a new option, what should be the name and description?

Test Plan

Test 1: moused selected:

#sh services

    ┌───────────────────────┤System Configuration├───────────────────────┐
    │ Choose the services you would like to be started at boot:          │  
    │ ┌────────────────────────────────────────────────────────────────┐ │  
    │ │[ ] local_unbound Local caching validating resolver             │ │  
    │ │[ ] sshd          Secure shell daemon                           │ │  
    │ │[X] moused        PS/2 mouse pointer on console                 │ │  
    │ │[ ] ntpdate       Synchronize system and network time at bootime│ │  
    │ │[ ] ntpd          Synchronize system and network time           │ │  
    │ │[ ] powerd        Adjust CPU frequency dynamically if supported │ │  
    │ │[ ] dumpdev       Enable kernel crash dumps to /var/crash       │ │  
    │ └────────────────────────────────────────────────────────────────┘ │  
    ├────────────────────────────────────────────────────────────────────┤  
    │                              [  OK  ]                              │  
    └────────────────────────────────────────────────────────────────────┘  
                                                                            
# cat /rc.conf.services
moused_enable="YES"
# Set dumpdev to "AUTO" to enable crash dumps, "NO" to disable
dumpdev="NO"

To note: moused_enable="YES"


Test 2: moused unselected:

# sh services

    ┌───────────────────────┤System Configuration├───────────────────────┐
    │ Choose the services you would like to be started at boot:          │  
    │ ┌────────────────────────────────────────────────────────────────┐ │  
    │ │[ ] local_unbound Local caching validating resolver             │ │  
    │ │[ ] sshd          Secure shell daemon                           │ │  
    │ │[ ] moused        PS/2 mouse pointer on console                 │ │  
    │ │[ ] ntpdate       Synchronize system and network time at bootime│ │  
    │ │[ ] ntpd          Synchronize system and network time           │ │  
    │ │[ ] powerd        Adjust CPU frequency dynamically if supported │ │  
    │ │[ ] dumpdev       Enable kernel crash dumps to /var/crash       │ │  
    │ └────────────────────────────────────────────────────────────────┘ │  
    ├────────────────────────────────────────────────────────────────────┤  
    │                              [  OK  ]                              │  
    └────────────────────────────────────────────────────────────────────┘  
 
# cat /rc.conf.services
moused_nondefault_enable="NO"
# Set dumpdev to "AUTO" to enable crash dumps, "NO" to disable
dumpdev="NO"

To note: moused_nondefault_enable="NO"

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped