Page MenuHomeFreeBSD
Differential D35176

net/isboot-kmod: Fix set but unused warnings.
ClosedPublic
Actions

Authored by jhb on May 11 2022, 8:37 PM.
Tags
None
Referenced Files
F81967713: D35176.id.diff
Tue, Apr 23, 9:31 PM
F81947030: D35176.diff
Tue, Apr 23, 2:45 PM
Unknown Object (File)
Sun, Apr 21, 6:03 AM
Unknown Object (File)
Sun, Apr 21, 6:03 AM
Unknown Object (File)
Sun, Apr 21, 6:03 AM
Unknown Object (File)
Sun, Apr 21, 5:49 AM
Unknown Object (File)
Sat, Apr 20, 3:38 PM
Unknown Object (File)
Jan 16 2024, 7:35 PM
View All 31 Files
Subscribers
mat

Details

Reviewers
john_jnielsen.net
Commits
R11:bd396a444474: net/isboot-kmod: Fix set but unused warnings.
Summary
  • Remove unused variables.
  • Add a __trace_unused helper macro to mark variables only used in ISBOOT_TRACE.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 45533
Build 42421: arc lint + arc unit

Event Timeline

jhb created this revision.May 11 2022, 8:37 PM
Herald added a subscriber: mat. · View Herald TranscriptMay 11 2022, 8:37 PM
jhb requested review of this revision.May 11 2022, 8:37 PM
Harbormaster completed remote builds in B45533: Diff 105873.May 11 2022, 8:37 PM
jhb added a reviewer: john_jnielsen.net.May 11 2022, 8:37 PM

Fixes build on recent main.

john_jnielsen.net accepted this revision.May 11 2022, 10:49 PM

Looks good to me. I'll work on a new version of the port with these changes. Thank you!

This revision is now accepted and ready to land.May 11 2022, 10:49 PM
Closed by commit R11:bd396a444474: net/isboot-kmod: Fix set but unused warnings. (authored by jhb). · Explain WhyMay 13 2022, 4:57 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: R11:bd396a444474: net/isboot-kmod: Fix set but unused warnings..

Revision Contents
Changeset List

PathSize
net/
isboot-kmod/
files/
74 lines
17 lines
226 lines

Diff 105873

View Options

net/isboot-kmod/files/patch-ibft.c

Loading...
View Options

net/isboot-kmod/files/patch-isboot.c

Loading...
View Options

net/isboot-kmod/files/patch-iscsi.c

Loading...