cmucl-extra: Deprecate ports
ClosedPublic
Actions

Authored by salvadore on May 10 2022, 1:05 PM.

Details

Reviewers

gerald
tcberner

Commits

R11:e978a52e0545: lang/cmucl and lang/cmucl-extra: Deprecate ports

Summary

lang/cmucl is not supported upstream since 2017 and broken since FreeBSD 12.1.

PR: 246640
Reported by: Bertrand Petit <bsdpr@phoe.frmug.org>

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

salvadore created this revision.May 10 2022, 1:05 PM

Herald added a subscriber: mat. · View Herald TranscriptMay 10 2022, 1:05 PM

salvadore requested review of this revision.May 10 2022, 1:05 PM

Harbormaster completed remote builds in B45511: Diff 105807.May 10 2022, 1:05 PM

Deprecate lang/cmucl-extra too.

Harbormaster completed remote builds in B45512: Diff 105808.May 10 2022, 1:12 PM

salvadore retitled this revision from lang/cmucl: Deprecate port to lang/cmucl and lang/cmucl-extra: Deprecate ports.May 10 2022, 1:13 PM

salvadore edited the summary of this revision. (Show Details)

diizzy added a subscriber: diizzy.May 10 2022, 1:41 PM

diizzy added inline comments.

lang/cmucl-extra/Makefile
15	This should go under LICENSE entry
lang/cmucl/Makefile
17	If possible provide a reference (upstream) in commit message and it seems to build on 13 but its broken?

diizzy added inline comments.May 10 2022, 1:48 PM

lang/cmucl/Makefile
17	Ahh, the PR made it clearer :-) You want to add BROKEN= ... BROKEN= doesn't run as expected on 12.1+ or something along those lines and remove that from DEPRECATED See https://cgit.freebsd.org/ports/commit/?id=781a05554b969000e09c2be0d7f202dcc1a05a44

salvadore added inline comments.May 10 2022, 2:10 PM

lang/cmucl/Makefile
17	Are you sure BROKEN is the right variable to add? According to https://docs.freebsd.org/en/books/porters-handbook/book/#dads-noinstall BROKEN is for temporary issues; on the other hand the porter's handbook also says "use IGNORE when a port does not work on the installed version of FreeBSD". Isn't IGNORE better in this case then?

diizzy added inline comments.May 10 2022, 2:38 PM

lang/cmucl/Makefile
17	While that phrasing might need to some polishing I would argue that it's temporary as the port is scheduled for removal. ;-) On a serious note, IGNORE would be used in case the port doesn't work (known/intentionally) on let's say a specific arch or let's say 13+. There are other use cases too such as licensing issues etc. Just setting DEPRECATE doesn't prevent people from installing a broken port while BROKEN will (also sets IGNORE), see https://cgit.freebsd.org/ports/tree/Mk/bsd.port.mk#n2801

I have added BROKEN and moved the variables under LICENSE. As for the reference, the PR is enough if I have understood correctly, is that right?

Harbormaster completed remote builds in B45524: Diff 105826.May 10 2022, 9:32 PM

salvadore edited the summary of this revision. (Show Details)May 10 2022, 9:33 PM

I suspect cmucl is broken since 12.0 (in the past I have maintained cmucl, for a short while), but since we have a report about 12.1, I wrote 12.1 in BROKEN.

gerald added inline comments.May 19 2022, 9:39 PM