Page MenuHomeFreeBSD

lang/cmucl and lang/cmucl-extra: Deprecate ports
Needs ReviewPublic

Authored by salvadore on Tue, May 10, 1:05 PM.

Details

Reviewers
gerald
tcberner
Summary

lang/cmucl is not supported upstream since 2017 and broken since FreeBSD 12.1.

PR: 246640
Reported by: Bertrand Petit <bsdpr@phoe.frmug.org>

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 45524
Build 42412: arc lint + arc unit

Event Timeline

Deprecate lang/cmucl-extra too.

salvadore retitled this revision from lang/cmucl: Deprecate port to lang/cmucl and lang/cmucl-extra: Deprecate ports.Tue, May 10, 1:13 PM
salvadore edited the summary of this revision. (Show Details)
diizzy added inline comments.
lang/cmucl-extra/Makefile
14

This should go under LICENSE entry

lang/cmucl/Makefile
16

If possible provide a reference (upstream) in commit message and it seems to build on 13 but its broken?

lang/cmucl/Makefile
16

Ahh, the PR made it clearer :-)
You want to add BROKEN= ...
BROKEN= doesn't run as expected on 12.1+
or something along those lines and remove that from DEPRECATED
See https://cgit.freebsd.org/ports/commit/?id=781a05554b969000e09c2be0d7f202dcc1a05a44

lang/cmucl/Makefile
16

Are you sure BROKEN is the right variable to add?
According to https://docs.freebsd.org/en/books/porters-handbook/book/#dads-noinstall BROKEN is for temporary issues; on the other hand the porter's handbook also says "use IGNORE when a port does not work on the installed version of FreeBSD". Isn't IGNORE better in this case then?

lang/cmucl/Makefile
16

While that phrasing might need to some polishing I would argue that it's temporary as the port is scheduled for removal. ;-)
On a serious note, IGNORE would be used in case the port doesn't work (known/intentionally) on let's say a specific arch or let's say 13+. There are other use cases too such as licensing issues etc. Just setting DEPRECATE doesn't prevent people from installing a broken port while BROKEN will (also sets IGNORE), see https://cgit.freebsd.org/ports/tree/Mk/bsd.port.mk#n2801

I have added BROKEN and moved the variables under LICENSE. As for the reference, the PR is enough if I have understood correctly, is that right?

I suspect cmucl is broken since 12.0 (in the past I have maintained cmucl, for a short while), but since we have a report about 12.1, I wrote 12.1 in BROKEN.