Page MenuHomeFreeBSD

dhclient: add support for FIB
AbandonedPublic

Authored by bapt on Tue, May 3, 7:13 AM.

Details

Reviewers
manu

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 45454
Build 42342: arc lint + arc unit

Event Timeline

bapt requested review of this revision.Tue, May 3, 7:13 AM
manu added a subscriber: manu.

Looks ok and fib 0 won't break.

This revision is now accepted and ready to land.Tue, May 3, 7:24 AM
tsoome added inline comments.
sbin/dhclient/dhclient-script
25

As discussed on IRC; route command already is picking this value as default; this suggests the ifconfig should do the same for consistent behavior. So, while this change does indeed fix the fib value use case, the proper fix (IMO) would be to fix ifconfig, and then this patch would not be needed.

In fact this change does not make sense, to be able to have dhclient properly set the routing table in the right fib, the way to do it is the following: 1. tag your iface: ifconfig $iface fib X, 2/ run dhclient in the right fib: setfib X $iface and that's all, route if fib aware already, and ifconfig is also fib aware as long as the fib is already set on the iface.