bsdinstall/script: umount before zpool export
ClosedPublic
Actions

Authored by corvink on May 3 2022, 5:56 AM.

Details

Reviewers

manu
nwhitehorn
emaste

Group Reviewers

releng

Commits

rG95c6bc5a03b9: bsdinstall/script: umount before zpool export
rG450b4ac23c75: bsdinstall/script: umount before zpool export

Summary

When running zpool export first, boot/efi and dev is still mounted so
zpool export fails. By running bsdinstall umount first the pool can be
cleanly exported.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

corvink created this revision.May 3 2022, 5:56 AM

Herald added a subscriber: imp. · View Herald TranscriptMay 3 2022, 5:56 AM

corvink requested review of this revision.May 3 2022, 5:56 AM

manu accepted this revision.May 3 2022, 7:20 AM

This revision is now accepted and ready to land.May 3 2022, 7:20 AM

manu added a reviewer: nwhitehorn.May 3 2022, 8:52 AM

And I think that this one is :
Fixes: 34766aa8cb "Fix scripted installs on EFI systems using ZFS root with zfsboot."

Hello re@
This breaks scripted install for 13.1
Should this be a candidate for another RC ?

emaste accepted this revision.May 3 2022, 1:07 PM

Closed by commit rG450b4ac23c75: bsdinstall/script: umount before zpool export (authored by corvink, committed by manu). · Explain WhyMay 3 2022, 2:06 PM

This revision was automatically updated to reflect the committed changes.

manu added a commit: rG450b4ac23c75: bsdinstall/script: umount before zpool export.

manu added a commit: rG95c6bc5a03b9: bsdinstall/script: umount before zpool export.May 16 2022, 3:27 PM

Revision Contents
Changeset List

Path

Size

usr.sbin/

bsdinstall/

scripts/

script

2 lines

Diff 105655

View Options

usr.sbin/bsdinstall/scripts/script

bsdinstall/script: umount before zpool exportClosedPublicActions