Paths

Table of Contentst

Differential D35096

mfc-candidates.sh: Set default to_branch for ports
ClosedPublic
Actions

Authored by jrm on Apr 29 2022, 4:38 PM.

Tags

None

Referenced Files

	F137668030: D35096.id105683.diff
	Mon, Nov 24, 8:34 PM

	F137668027: D35096.id105549.diff
	Mon, Nov 24, 8:34 PM

	F137668024: D35096.id105553.diff
	Mon, Nov 24, 8:34 PM

	F137668019: D35096.id105554.diff
	Mon, Nov 24, 8:34 PM

	F137668017: D35096.id.diff
	Mon, Nov 24, 8:34 PM

	F137668014: D35096.id105550.diff
	Mon, Nov 24, 8:34 PM

	F137668015: D35096.id105552.diff
	Mon, Nov 24, 8:34 PM

	F137667722: D35096.diff
	Mon, Nov 24, 8:33 PM

Subscribers

Details

Reviewers

emaste
jhb

Commits

rG4b3bf909005a: mfc-candidates.sh: Set default target branch for ports

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jrm created this revision.Apr 29 2022, 4:38 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 29 2022, 4:38 PM

jrm requested review of this revision.Apr 29 2022, 4:38 PM

Harbormaster completed remote builds in B45427: Diff 105549.Apr 29 2022, 4:39 PM

Remove empty line

Harbormaster completed remote builds in B45428: Diff 105550.Apr 29 2022, 4:40 PM

emaste added inline comments.Apr 29 2022, 4:57 PM

tools/tools/git/mfc-candidates.sh
32–33	I think you could move this into the src "else" case below now. I'm not sure if there is a suitable default is for ports, but it's definitely not stable/13 :)
36	Maybe `2>/dev/null` in case it's run where there is no "freebsd" remote?

Set default to_branch under each if clause
Send unwanted error output to /dev/null
Bail if pwd is not under a ports or src repository

Harbormaster completed remote builds in B45429: Diff 105552.Apr 29 2022, 5:18 PM

jrm marked 2 inline comments as done.Apr 29 2022, 5:18 PM

Fix comment location

Harbormaster completed remote builds in B45430: Diff 105553.Apr 29 2022, 5:20 PM

Fix quoting issue

Harbormaster completed remote builds in B45431: Diff 105554.Apr 29 2022, 5:25 PM

jhb accepted this revision.May 4 2022, 6:35 PM

This revision is now accepted and ready to land.May 4 2022, 6:35 PM

emaste accepted this revision.May 4 2022, 6:38 PM

Closed by commit rG4b3bf909005a: mfc-candidates.sh: Set default target branch for ports (authored by jrm). · Explain WhyMay 4 2022, 7:48 PM

This revision was automatically updated to reflect the committed changes.

jrm added a commit: rG4b3bf909005a: mfc-candidates.sh: Set default target branch for ports.

Revision Contents
Changeset List

Path

Size

tools/

tools/

git/

mfc-candidates.sh

39 lines

Diff 105683

tools/tools/git/mfc-candidates.sh

Loading...