This version is deprecated and unsupported upstream. The port needs an update, but this might require a fair amount of time. In alternative to it, it is possibile to use OpenVPN or Wireguard with configuration files provided by ProtonVPN.
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 45415 Build 42303: arc lint + arc unit
Event Timeline
Comment Actions
If it's unsupported upstream I'd suggest that you set expiration date and bring back the port if needed instead of having deprecated "placeholders" in tree.
Comment Actions
This version is indeed unsupported upstream, but the port still works, it can still be useful.
I read in the Porter's handbook:
It is possible to set DEPRECATED without an EXPIRATION_DATE (for instance, recommending a newer version of the port), but the converse does not make any sense.
Maybe I should make it clearer in the DEPRECATED message that the port works? I might have given the impression that the port is broken. Or should I set an expiration date anyway just as you suggested? In that case I would remove my adoption: I don't think it makes sense to adopt soon to be removed ports.
Comment Actions
I would argue that it's bad practice to have unsupported security related software and if there's no clear timeline for updating in tree. It's "better" (from a security perspective) to deprecate and set a expiration date as it doesn't prevent anyone who's interested to update it within that date or bring it back later. As far as I can tell you can also do without the port just fine?
Edit: That's my take on it ;-)
Comment Actions
I agree with you dizzy. Moreover, in my experience, software from this company is not easy at all to port, so I am unsure that I will ever succeed updating the port. I follow your advice.
Thanks you very much for your review.
Comment Actions
Some minor suggestions for the actual text (and as you mentioned out of band you'll adjust the date bit).
| security/protonvpn-cli/Makefile | ||
|---|---|---|
| 16 | We can simplify this to "which would require a fair amount of effort". (Well, not really simpler, though avoiding the "but" and being more affirmative.) And then "Use OpenVPN or Wireguard with ... instead.", which is more from the user perspective. | |
Comment Actions
Sorry, I forgot to add the differential review link to the commit message.
So I close the review manually.
Here is the link to the commit for anyone interested:
https://reviews.freebsd.org/R11:e8af334ea352
I made the fixes suggested by @gerald and moved forward the expiration date to 2022-06-25, close to the end of the quarter as suggested by @tcberner.