Fix trivial ACLs on directories exported via NFSv4.
ClosedPublic
Actions

Authored by trasz on Aug 27 2015, 9:03 AM.

Details

Reviewers

Commits

rS287256: Fix an NFS server bug that manifested in "ls -al" displaying a plus

Summary

The patch below fixes a bug that manifested in "ls -al" displaying a plus
sign on every directory exported via NFSv4 with NFSv4 ACLs enabled.

No idea why this particular bit - ACL_SYNCHRONIZE - was missing for the
VDIR case.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

trasz updated this revision to Diff 8252.Aug 27 2015, 9:03 AM

trasz retitled this revision from to Fix trivial ACLs on directories exported via NFSv4..

trasz updated this object.

trasz edited the test plan for this revision. (Show Details)

Herald added a subscriber: imp. · View Herald TranscriptAug 27 2015, 9:03 AM

trasz added a reviewer: rmacklem.Aug 27 2015, 9:05 AM

Looks fine to me, although I'll admit I have no idea what "SYNCHRONIZE"
means? (I was told it was a Windows thing, which was probably why I
didn't include it.)

This revision is now accepted and ready to land.Aug 27 2015, 10:46 PM

It is a Windows thing, and it's ignored in FreeBSD. Still - it is included in !VDIR, and not included in VDIR; do you remember why it's so? Compatibility with some other implementation, perhaps?

I don't recall.

I suspect I believed that it didn't apply to directories for some
reason, but I don't know where I got that from. As already noted,
I don't see a problem with the patch.

Closed by commit rS287256: Fix an NFS server bug that manifested in "ls -al" displaying a plus (authored by trasz). · Explain WhyAug 28 2015, 2:26 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

fs/

nfs/

nfs_commonacl.c

2 lines

Diff 8296

View Options

head/sys/fs/nfs/nfs_commonacl.c

Fix trivial ACLs on directories exported via NFSv4.ClosedPublicActions