bsddialog(3): fix disabled shadow
ClosedPublic
Actions

Authored by asiciliano on Apr 19 2022, 2:02 PM.

Details

Reviewers

bapt

Commits

rGb9e5884ef786: bsddialog(3): fix disabled shadow

Summary

Fix dialogs building and updating segmentation fault with disabled shadow (conf.shadow=false and implicitly bsddialog --no-shadow).
No component in BASE is affected.
Moreover delete WARNS: all warnings were fixed in upstream and imported in 0.2.

Test Plan

Trivial:

-       if (shadow != NULL)
+       if (conf->shadow)

(Probably the error was introduced during the last refactoring to improve the dialogs building process).

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

asiciliano requested review of this revision.Apr 19 2022, 2:02 PM

asiciliano created this revision.

bapt accepted this revision.Apr 20 2022, 12:37 PM

This revision is now accepted and ready to land.Apr 20 2022, 12:37 PM

Closed by commit rGb9e5884ef786: bsddialog(3): fix disabled shadow (authored by asiciliano). · Explain WhyApr 20 2022, 3:53 PM

This revision was automatically updated to reflect the committed changes.

asiciliano added a commit: rGb9e5884ef786: bsddialog(3): fix disabled shadow.

Herald added a subscriber: imp. · View Herald TranscriptApr 20 2022, 3:53 PM

Revision Contents
Changeset List

Path

Size

contrib/

bsddialog/

lib/

lib_util.c

6 lines

lib/

libbsddialog/

Makefile

2 lines

Diff 105208

View Options

contrib/bsddialog/lib/lib_util.c