config: backwards compatibility for profile directives
ClosedPublic
Actions

Authored by kevans on Apr 6 2022, 5:20 PM.

Details

Reviewers

imp
kib

Summary

We've removed this support in FreeBSD 14.0, but we shuld recognize the
directives so that we can still build 12.x/13.x kernels that may use
them.

Emit a warning so that one has a fighting chance of realizing that it's
not supported and they need an older config(8). Avoid documenting any
of this still being recognized.

Extra newline is included after these messages to try and separate them
from the wall of text that they otherwise appear in.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 45031
Build 41919: arc lint + arc unit

Event Timeline

kevans requested review of this revision.Apr 6 2022, 5:20 PM

kevans created this revision.

Harbormaster completed remote builds in B45031: Diff 104673.Apr 6 2022, 5:20 PM

imp accepted this revision.Apr 6 2022, 5:22 PM

imp added inline comments.

usr.sbin/config/config.y
200	This will become an error after

This revision is now accepted and ready to land.Apr 6 2022, 5:22 PM

imp added inline comments.Apr 6 2022, 5:22 PM

usr.sbin/config/config.y
200	"This will become an error after FreeBSD 13.x EOL." maybe?

I do not object, but arguably this is the first time ever I see a compat for config. All other features removal resulted in hard error for unmodified configs.

Also 'profile' with mcounters was not working for SMP ever, I believe. So why?

In D34805#788848, @kib wrote:

I do not object, but arguably this is the first time ever I see a compat for config. All other features removal resulted in hard error for unmodified configs.

Also 'profile' with mcounters was not working for SMP ever, I believe. So why?

Good point; looking back, I apparently missed that it was NOTES in stable/13 that they hit problems with. Maybe we should just MFC (edit: that part of) aa3ea612be365 and continue punting on this until someone comes up with a broken runnable config.

In D34805#788854, @kevans wrote:

In D34805#788848, @kib wrote:

I do not object, but arguably this is the first time ever I see a compat for config. All other features removal resulted in hard error for unmodified configs.

Also 'profile' with mcounters was not working for SMP ever, I believe. So why?

Good point; looking back, I apparently missed that it was NOTES in stable/13 that they hit problems with. Maybe we should just MFC (edit: that part of) aa3ea612be365 and continue punting on this until someone comes up with a broken runnable config.