.
ClosedPublic
Actions

Authored by trasz on Aug 23 2015, 3:36 PM.

Details

Reviewers

Commits

rS293742: MFC r287107:
rS287107: Make vfs_unmountall() unmount /dev after /, not before. The only

Summary

Without this change, vfs_unmountall() tries to unmount /dev
before unmounting /. The only reason this doesn't result in unclean
shutdown is that devfs ignores MNT_FORCE flag.

This could be done in a more complicated ways - eg using a new mount
flag - but I don't see the advantages over this - quite basic - solution.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 199
Build 199: arc lint + arc unit

Event Timeline

trasz updated this revision to Diff 8144.Aug 23 2015, 3:36 PM

trasz retitled this revision from to Unmount /dev after /..

trasz updated this object.

trasz edited the test plan for this revision. (Show Details)

Herald added a subscriber: imp. · View Herald TranscriptAug 23 2015, 3:36 PM

Oh, one more thing - after this change, the "mp" argument in vfs_mountroot_devfs() is _probably_ superfluous. However, the logic in vfs_mountroot() is kind of convoluted; it uses some config file, but it's completely undocumented, and thus hard to test. So I'd rather change as little code there as possible to avoid breaking something.

Remove debugging printf.

kib added inline comments.Aug 24 2015, 9:26 AM

sys/kern/vfs_subr.c
3590	Since you check rootdevmp for NULL, I suggest assigning NULL to it after successfull unmount. Also, consider a case when user did umount /dev manually.