Page MenuHomeFreeBSD

gbde: stop rebuilding sha512 bits
ClosedPublic

Authored by kevans on Mar 25 2022, 1:57 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 11 2024, 10:39 PM
Unknown Object (File)
Dec 20 2023, 3:49 AM
Unknown Object (File)
Dec 12 2023, 12:01 PM
Unknown Object (File)
Sep 8 2023, 9:48 AM
Unknown Object (File)
Jun 14 2023, 12:04 AM
Unknown Object (File)
May 2 2023, 7:23 AM
Unknown Object (File)
Apr 26 2023, 5:37 AM
Unknown Object (File)
Apr 25 2023, 4:55 PM
Subscribers

Details

Summary

In the early days of gbde, it linked against libmd. Shortly after
conception, phk replaced ARC4 with SHA-512, but libmd did not have SHA2
at the time thus he built a copy of sha2.c for gbde.

Fast forward 3 years, cperciva adds SHA2 to libmd -- this makes gbde's
build of sha2.c redundant, but it's (understandably) overlooked. Let's
simplify the gbde build now and just assume that libmd includes the most
optimal implementation.

Reported by: koobs (weird lto errors?)

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Apr 26 2023, 5:37 AM
This revision was automatically updated to reflect the committed changes.