Page MenuHomeFreeBSD

gbde: stop rebuilding sha512 bits
ClosedPublic

Authored by kevans on Mar 25 2022, 1:57 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 17, 12:56 PM
Unknown Object (File)
Wed, Apr 15, 4:02 AM
Unknown Object (File)
Tue, Apr 14, 1:39 PM
Unknown Object (File)
Sat, Apr 11, 1:10 PM
Unknown Object (File)
Thu, Apr 9, 8:19 PM
Unknown Object (File)
Tue, Apr 7, 9:09 PM
Unknown Object (File)
Tue, Mar 31, 2:01 PM
Unknown Object (File)
Mar 2 2026, 6:34 PM
Subscribers

Details

Summary

In the early days of gbde, it linked against libmd. Shortly after
conception, phk replaced ARC4 with SHA-512, but libmd did not have SHA2
at the time thus he built a copy of sha2.c for gbde.

Fast forward 3 years, cperciva adds SHA2 to libmd -- this makes gbde's
build of sha2.c redundant, but it's (understandably) overlooked. Let's
simplify the gbde build now and just assume that libmd includes the most
optimal implementation.

Reported by: koobs (weird lto errors?)

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Apr 26 2023, 5:37 AM
This revision was automatically updated to reflect the committed changes.