sound: test PCM_REGISTERED before PCM_DETACHING
ClosedPublic
Actions

Authored by emaste on Mar 23 2022, 8:05 PM.

Details

Reviewers

Commits

rGaeb4214375b7: sound: test PCM_REGISTERED before PCM_DETACHING
rG74f11a40f8e4: sound: test PCM_REGISTERED before PCM_DETACHING
rGda03ac41c9bc: sound: test PCM_REGISTERED before PCM_DETACHING

Summary

PCM_REGISTERED(d) tests that d is not NULL, so put that check first as we may have cases where devclass_get_softc has a null entry

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=262671

Looks good.

Maybe you could combine that repeated case into an own macro. But it is also good as is.

This revision is now accepted and ready to land.Mar 23 2022, 10:14 PM

Maybe you could combine that repeated case into an own macro. But it is also good as is.

Might do that as a follow-on change, perhaps along with some diagnostics with the originator of the PR to understand why there is a NULL entry in the first place.

Closed by commit rGda03ac41c9bc: sound: test PCM_REGISTERED before PCM_DETACHING (authored by emaste). · Explain WhyMar 24 2022, 12:10 AM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rGda03ac41c9bc: sound: test PCM_REGISTERED before PCM_DETACHING.

Herald added a subscriber: imp. · View Herald TranscriptMar 24 2022, 12:10 AM

emaste added a commit: rG74f11a40f8e4: sound: test PCM_REGISTERED before PCM_DETACHING.Mar 30 2022, 8:44 PM

emaste added a commit: rGaeb4214375b7: sound: test PCM_REGISTERED before PCM_DETACHING.Mar 31 2022, 12:32 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

sound/

pcm/

mixer.c

10 lines

Diff 104136

View Options

sound: test PCM_REGISTERED before PCM_DETACHINGClosedPublicActions