Page MenuHomeFreeBSD
Differential D3464

Constantify lookup key in ifa_ifwith* functions.
ClosedPublic
Actions

Authored by melifaro on Aug 23 2015, 10:55 AM.
Tags
None
Referenced Files
F168671640: D3464.id.diff
Sat, Aug 29, 1:33 PM
F168563042: D3464.id8140.diff
Sat, Aug 29, 1:13 AM
F168563013: D3464.id8502.diff
Sat, Aug 29, 1:13 AM
Unknown Object (File)
Wed, Aug 26, 8:51 PM
Unknown Object (File)
Wed, Aug 26, 4:24 PM
Unknown Object (File)
Wed, Aug 26, 4:06 PM
Unknown Object (File)
Wed, Aug 26, 7:53 AM
Unknown Object (File)
Tue, Aug 25, 5:42 PM
View All Files
Subscribers
imp

Details

Reviewers
ae
Group Reviewers
network
Commits
rS287476: Constantify lookup key in ifa_ifwith* functions.
Summary

Some places in our network stack already have const
arguments (like if_output() routines and LLE functions).

Code using ifa_ifwith (and similar functins) along with
LLE/_output functions is currently bound to use tricks
like __DECONST(). Provide a cleaner way by making sockaddr
lookup key really constant.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

melifaro updated this revision to Diff 8140.Aug 23 2015, 10:55 AM
melifaro retitled this revision from to Constantify lookup key in ifa_ifwith* functions..
melifaro updated this object.
melifaro edited the test plan for this revision. (Show Details)
melifaro added a reviewer: network.
Herald added a subscriber: imp. · View Herald TranscriptAug 23 2015, 10:55 AM
ae accepted this revision.Sep 4 2015, 9:22 AM
ae added a reviewer: ae.
This revision is now accepted and ready to land.Sep 4 2015, 9:22 AM
Closed by commit rS287476: Constantify lookup key in ifa_ifwith* functions. (authored by melifaro). · Explain WhySep 5 2015, 5:33 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
net/
34 lines
1 line
17 lines
4 lines
2 lines

Diff 8502

View Options

head/sys/net/if.c

Loading...
View Options

head/sys/net/if_dl.h

Loading...
View Options

head/sys/net/if_var.h

Loading...
View Options

head/sys/net/route.h

Loading...
View Options

head/sys/net/route.c

Loading...