Differential D34594

arm: Zero padding in mcontext_vfp_t in get_vfpcontext().
ClosedPublic
Actions

Authored by jhb on Mar 17 2022, 10:34 PM.

Tags

None

Referenced Files

	F166892648: D34594.diff
	Mon, Aug 17, 2:02 PM

	Unknown Object (File)
	Thu, Aug 13, 9:57 PM

	Unknown Object (File)
	Thu, Aug 13, 9:37 PM

	Unknown Object (File)
	Thu, Aug 13, 5:44 PM

	Unknown Object (File)
	Wed, Aug 12, 10:40 PM

	Unknown Object (File)
	Tue, Aug 11, 11:08 PM

	Unknown Object (File)
	Mon, Aug 10, 10:03 AM

	Unknown Object (File)
	Sat, Aug 8, 4:37 AM

Subscribers

Details

Reviewers

markj
andrew
imp

Commits

rGfb3fa01a2df5: arm: Zero padding in mcontext_vfp_t in get_vfpcontext().
rGb234b8d911cd: arm: Zero padding in mcontext_vfp_t in get_vfpcontext().

Summary

This can leak kernel stack data otherwise.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Mar 17 2022, 10:34 PM

Herald added a subscriber: imp. · View Herald TranscriptMar 17 2022, 10:34 PM

jhb requested review of this revision.Mar 17 2022, 10:34 PM

Harbormaster completed remote builds in B44816: Diff 103966.Mar 17 2022, 10:34 PM

markj accepted this revision.Mar 17 2022, 10:38 PM

This revision is now accepted and ready to land.Mar 17 2022, 10:38 PM

So it's fine as is, but a pad might be better...

sys/arm/arm/exec_machdep.c
113	Or we could add a a 'mcv_pad' int32_t field and just set that... It's the only bytes that need to be set and setting the other 32*8+4 (260 bytes)....

andrew added inline comments.Mar 18 2022, 11:14 AM

sys/arm/arm/exec_machdep.c
113	We should put a pad field in as the compiler could still leak kernel stack data via the padding.

jhb added inline comments.Mar 23 2022, 8:25 PM

sys/arm/arm/exec_machdep.c
113	Modern compilers are smart enough given that memcpy and memset are builtins to only memset the bits that aren't overwritten by the memcpy. I'm not sure of the value of making the padding field explicit?

Closed by commit rGb234b8d911cd: arm: Zero padding in mcontext_vfp_t in get_vfpcontext(). (authored by jhb). · Explain WhyMar 25 2022, 5:00 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGb234b8d911cd: arm: Zero padding in mcontext_vfp_t in get_vfpcontext()..

jhb added a commit: rGfb3fa01a2df5: arm: Zero padding in mcontext_vfp_t in get_vfpcontext()..May 13 2022, 5:43 PM

Revision Contents
Changeset List

Path

Size

sys/

arm/

arm/

1 line

Diff 104200

sys/arm/arm/exec_machdep.c

Loading...