Page MenuHomeFreeBSD

rman resource kvaddr_t
Needs ReviewPublic

Authored by br on Mar 10 2022, 6:02 PM.
Tags
None
Referenced Files
F171470295: D34519.id.diff
Fri, Sep 11, 7:23 AM
Unknown Object (File)
Sun, Aug 23, 6:35 AM
Unknown Object (File)
Sat, Aug 22, 6:39 PM
Unknown Object (File)
Fri, Aug 21, 7:28 PM
Unknown Object (File)
Thu, Aug 20, 7:52 PM
Unknown Object (File)
Tue, Aug 18, 8:11 PM
Unknown Object (File)
Mon, Aug 17, 1:27 AM
Unknown Object (File)
Aug 12 2026, 3:27 PM
Subscribers
None

Details

Reviewers
jhb
jrtc27
kib
Summary

Replace pointer members of structs u_resource and u_rman to kvaddr_t.
These structs exported to userspace, but the members never used as pointers in userspace (but instead used as unique idenitifiers).

These breaks a bit of ABI but we believe that only libdevinfo uses it (?).

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

br requested review of this revision.Mar 10 2022, 6:02 PM
br created this revision.

Motivation is so the sysctl works for non-native ABIs.

Justification for the ABI break is I can't find any references to the structs via code search.debian.net, libdevinfo is the only in-tree consumer and it only affects 32-bit architectures.