Page MenuHomeFreeBSD

rman resource kvaddr_t
Needs ReviewPublic

Authored by br on Mar 10 2022, 6:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jun 26, 12:15 PM
Unknown Object (File)
Thu, Jun 25, 11:14 AM
Unknown Object (File)
Wed, Jun 24, 7:55 AM
Unknown Object (File)
May 12 2026, 12:26 AM
Unknown Object (File)
May 7 2026, 12:52 PM
Unknown Object (File)
Apr 28 2026, 6:49 PM
Unknown Object (File)
Apr 27 2026, 4:26 PM
Unknown Object (File)
Apr 23 2026, 10:13 PM
Subscribers
None

Details

Reviewers
jhb
jrtc27
kib
Summary

Replace pointer members of structs u_resource and u_rman to kvaddr_t.
These structs exported to userspace, but the members never used as pointers in userspace (but instead used as unique idenitifiers).

These breaks a bit of ABI but we believe that only libdevinfo uses it (?).

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

br requested review of this revision.Mar 10 2022, 6:02 PM
br created this revision.

Motivation is so the sysctl works for non-native ABIs.

Justification for the ABI break is I can't find any references to the structs via code search.debian.net, libdevinfo is the only in-tree consumer and it only affects 32-bit architectures.