Page MenuHomeFreeBSD

rman resource kvaddr_t
Needs ReviewPublic

Authored by br on Mar 10 2022, 6:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Nov 8 2025, 10:14 PM
Unknown Object (File)
Oct 25 2025, 11:51 PM
Unknown Object (File)
Oct 25 2025, 4:22 PM
Unknown Object (File)
Oct 24 2025, 1:44 PM
Unknown Object (File)
Oct 21 2025, 3:41 AM
Unknown Object (File)
Oct 19 2025, 11:48 AM
Unknown Object (File)
Oct 19 2025, 11:48 AM
Unknown Object (File)
Oct 18 2025, 9:53 PM
Subscribers
None

Details

Reviewers
jhb
jrtc27
kib
Summary

Replace pointer members of structs u_resource and u_rman to kvaddr_t.
These structs exported to userspace, but the members never used as pointers in userspace (but instead used as unique idenitifiers).

These breaks a bit of ABI but we believe that only libdevinfo uses it (?).

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

br requested review of this revision.Mar 10 2022, 6:02 PM
br created this revision.

Motivation is so the sysctl works for non-native ABIs.

Justification for the ABI break is I can't find any references to the structs via code search.debian.net, libdevinfo is the only in-tree consumer and it only affects 32-bit architectures.