Page MenuHomeFreeBSD

rman resource kvaddr_t
Needs ReviewPublic

Authored by br on Mar 10 2022, 6:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 14, 6:46 AM
Unknown Object (File)
Tue, Apr 14, 12:01 AM
Unknown Object (File)
Thu, Apr 9, 4:52 AM
Unknown Object (File)
Mon, Apr 6, 4:57 PM
Unknown Object (File)
Sun, Mar 29, 2:30 PM
Unknown Object (File)
Sat, Mar 28, 9:24 AM
Unknown Object (File)
Mar 17 2026, 4:21 PM
Unknown Object (File)
Mar 17 2026, 12:13 PM
Subscribers
None

Details

Reviewers
jhb
jrtc27
kib
Summary

Replace pointer members of structs u_resource and u_rman to kvaddr_t.
These structs exported to userspace, but the members never used as pointers in userspace (but instead used as unique idenitifiers).

These breaks a bit of ABI but we believe that only libdevinfo uses it (?).

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

br requested review of this revision.Mar 10 2022, 6:02 PM
br created this revision.

Motivation is so the sysctl works for non-native ABIs.

Justification for the ABI break is I can't find any references to the structs via code search.debian.net, libdevinfo is the only in-tree consumer and it only affects 32-bit architectures.