Page MenuHomeFreeBSD

rman resource kvaddr_t
Needs ReviewPublic

Authored by br on Mar 10 2022, 6:02 PM.
Tags
None
Referenced Files
F166268128: D34519.id103725.diff
Wed, Aug 12, 3:27 PM
Unknown Object (File)
Tue, Aug 11, 1:29 PM
Unknown Object (File)
Sat, Aug 8, 5:42 PM
Unknown Object (File)
Sun, Aug 2, 3:24 AM
Unknown Object (File)
Sat, Aug 1, 8:40 AM
Unknown Object (File)
Tue, Jul 28, 5:00 AM
Unknown Object (File)
Jun 26 2026, 12:15 PM
Unknown Object (File)
Jun 25 2026, 11:14 AM
Subscribers
None

Details

Reviewers
jhb
jrtc27
kib
Summary

Replace pointer members of structs u_resource and u_rman to kvaddr_t.
These structs exported to userspace, but the members never used as pointers in userspace (but instead used as unique idenitifiers).

These breaks a bit of ABI but we believe that only libdevinfo uses it (?).

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

br requested review of this revision.Mar 10 2022, 6:02 PM
br created this revision.

Motivation is so the sysctl works for non-native ABIs.

Justification for the ABI break is I can't find any references to the structs via code search.debian.net, libdevinfo is the only in-tree consumer and it only affects 32-bit architectures.