if_re: generate an address if there is none in the EEPROM
ClosedPublic
Actions

Authored by evgeni_debian.org on Mar 8 2022, 8:20 PM.

Details

Reviewers

Group Reviewers

Commits

rGfcb6cac22397: if_re: Generate an address if there is none in the EEPROM
rG55747938b5c4: if_re: Generate an address if there is none in the EEPROM

Summary

There exists hardware that has no ethernet address burned into the EEPROM. Loading if_re on such a HW brings the device up with '00:00:00:00:00:00' as the address, and that doesn't get you too far in a real network.

Other drivers use ether_gen_addr(9) in such cases, to generate an address, and so should if_re.

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=262406

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

evgeni_debian.org created this revision.Mar 8 2022, 8:20 PM

Herald added a subscriber: imp. · View Herald TranscriptMar 8 2022, 8:20 PM

evgeni_debian.org requested review of this revision.Mar 8 2022, 8:20 PM

bz added a reviewer: network.Mar 12 2022, 11:49 AM

now also at https://github.com/freebsd/freebsd-src/pull/670

No brainer yes. :)

This revision is now accepted and ready to land.Feb 27 2023, 10:17 PM

Closed by commit rG55747938b5c4: if_re: Generate an address if there is none in the EEPROM (authored by evgeni_debian.org, committed by imp). · Explain WhyFeb 27 2023, 10:56 PM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG55747938b5c4: if_re: Generate an address if there is none in the EEPROM.

imp added a commit: rGfcb6cac22397: if_re: Generate an address if there is none in the EEPROM.Feb 19 2024, 2:56 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

re/

if_re.c

5 lines

Diff 118038

View Options

if_re: generate an address if there is none in the EEPROMClosedPublicActions