ocs_fc: Support persistent topology feature
ClosedPublic
Actions

Authored by ram on Mar 3 2022, 4:15 PM.

Details

Reviewers

ken
mav

Commits

rG95c714c6c473: ocs_fc: Support persistent topology feature
rG3ca1c43d1ca9: ocs_fc: Support persistent topology feature
rG965e2154e768: ocs_fc: Support persistent topology feature

Summary

Enable persistent topology across power cycles/firmware resets.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ram created this revision.Mar 3 2022, 4:15 PM

Herald added a subscriber: imp. · View Herald TranscriptMar 3 2022, 4:15 PM

ram requested review of this revision.Mar 3 2022, 4:15 PM

Harbormaster completed remote builds in B44628: Diff 103449.Mar 3 2022, 4:15 PM

I have no objections. Just few thoughts inline. It would help if you describe it a bit more in description, so we would not have to guess what it should do.

sys/dev/ocs_fc/ocs_xport.c
399	If I read this right, setting topology with tunable once will make it persistent, and it will remain so even when tunable is later removed until I guess it is reset to auto via sysctl?
sys/dev/ocs_fc/sli4.c
818	Why this branching is needed at all? Why not just assign enable_topology_failover always?
882	As I see return value of this and at least few other functions I checked is only used as boolean. Just a bit odd.

This revision is now accepted and ready to land.Mar 3 2022, 7:02 PM

ram marked an inline comment as done.Mar 4 2022, 4:26 AM

ram added inline comments.

sys/dev/ocs_fc/ocs_xport.c
399	Yes, topology will be persistent across reboots until changed via sysctl/module param. The persistent topology feature helps the emulex adapter BIOS to set the same topology.
sys/dev/ocs_fc/sli4.c
818	Will change it to assign tf directly.
882	Yes, most of the SLI interface function had this issue. I will take that task in a different patch.