Page MenuHomeFreeBSD
Differential D34355

rtsold: fix memory leak in script execution
ClosedPublic
Actions

Authored by vangyzen on Feb 23 2022, 4:57 PM.
Tags
None
Referenced Files
F137382861: D34355.id103226.diff
Sat, Nov 22, 11:17 PM
Unknown Object (File)
Thu, Nov 13, 11:37 PM
Unknown Object (File)
Wed, Nov 5, 6:03 AM
Unknown Object (File)
Wed, Nov 5, 6:02 AM
Unknown Object (File)
Wed, Nov 5, 6:02 AM
Unknown Object (File)
Wed, Nov 5, 5:58 AM
Unknown Object (File)
Oct 17 2025, 12:09 PM
Unknown Object (File)
Oct 14 2025, 3:37 AM
View All 90 Files
Subscribers
badger
dab
imp

Details

Reviewers
markj
Commits
rGbf75cc097a24: rtsold: fix memory leak in script execution
rG331b84b5db11: rtsold: fix memory leak in script execution
Summary

Since commit 04e9edb54428, rtsold has leaked the memory for the
argument vector of every script it runs.

Fixes: 04e9edb5442826a14616157962361ff81e4a38fe
MFC after: 1 week
Sponsored by: Dell EMC Isilon

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

vangyzen created this revision.Feb 23 2022, 4:57 PM
Herald added subscribers: dab, badger, imp. · View Herald TranscriptFeb 23 2022, 4:57 PM
vangyzen requested review of this revision.Feb 23 2022, 4:57 PM
Harbormaster completed remote builds in B44548: Diff 103157.Feb 23 2022, 4:57 PM
markj accepted this revision.Feb 23 2022, 5:00 PM
markj added inline comments.
usr.sbin/rtsold/cap_script.c
201

I'd add a new error variable, but I'm ok with it either way.

This revision is now accepted and ready to land.Feb 23 2022, 5:00 PM
Closed by commit rG331b84b5db11: rtsold: fix memory leak in script execution (authored by vangyzen). · Explain WhyFeb 25 2022, 3:32 PM
This revision was automatically updated to reflect the committed changes.
vangyzen added a commit: rG331b84b5db11: rtsold: fix memory leak in script execution.
vangyzen added a commit: rGbf75cc097a24: rtsold: fix memory leak in script execution.Mar 2 2022, 10:00 PM

Revision Contents
Changeset List

PathSize
usr.sbin/
rtsold/
6 lines

Diff 103226

View Options

usr.sbin/rtsold/cap_script.c

Loading...