rc: Allow the removal of firstboot_sentinel on read-only file systems
ClosedPublic
Actions

Authored by jlduran on Feb 4 2022, 1:02 AM.

Details

Reviewers

emaste
imp

Commits

rGcb51e2bc3db7: rc: Allow the removal of firstboot_sentinel on read-only file systems

Summary

NanoBSD or, more generally, systems with root_rw_mount="NO" are not able to remove the firstboot_sentinel file, typically /firstboot, because the logic in /etc/rc is currently inverted.

When checkyesno root_rw_mount tests on a read-only file system, the return is 1, hence avoiding the option to mount the system read-write.

Restore the ability to remove the firstboot_sentinel file on read-only mounted file systems.

This change was introduced in 40adda8665bbcda1bad7e3a6a3c1031027faf39a, and partially fixed in 1ce07411fae8986f3acc293c9fb9ebee5211056a.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

jlduran created this revision.Feb 4 2022, 1:02 AM

Herald added a subscriber: imp. · View Herald TranscriptFeb 4 2022, 1:02 AM

jlduran requested review of this revision.Feb 4 2022, 1:02 AM

jlduran added a parent revision: D34165: rc: Remove extra white space.

jlduran edited the summary of this revision. (Show Details)Feb 4 2022, 1:07 AM

jlduran retitled this revision from rc: Allow removal of firstboot_sentinel on a ro FS to rc: Allow the removal of firstboot_sentinel on read-only file systems.

jlduran added reviewers: emaste, imp.Feb 4 2022, 10:44 AM

imp accepted this revision.Feb 10 2022, 7:42 PM

This revision is now accepted and ready to land.Feb 10 2022, 7:42 PM

Closed by commit rGcb51e2bc3db7: rc: Allow the removal of firstboot_sentinel on read-only file systems (authored by jlduran, committed by imp). · Explain WhyFeb 10 2022, 7:44 PM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rGcb51e2bc3db7: rc: Allow the removal of firstboot_sentinel on read-only file systems.