Differential D34122

<sys/bitstring.h>: Cast _BITSTR_BITS to int in a ternary operator.
ClosedPublic
Actions

Authored by jhb on Feb 1 2022, 1:08 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Jan 31, 11:09 AM

	Unknown Object (File)
	Fri, Jan 30, 10:23 PM

	Unknown Object (File)
	Wed, Jan 28, 3:25 PM

	Unknown Object (File)
	Tue, Jan 27, 1:22 PM

	Unknown Object (File)
	Sat, Jan 24, 10:25 PM

	Unknown Object (File)
	Sat, Jan 24, 9:55 PM

	Unknown Object (File)
	Jan 2 2026, 6:58 AM

	Unknown Object (File)
	Nov 28 2025, 9:37 AM

View All 96 Files

Subscribers

Details

Reviewers

rlibby
dougm

Commits

rG897877ae644d: <sys/bitstring.h>: Cast _BITSTR_BITS to int in a ternary operator.
rG8a67a1a9646e: <sys/bitstring.h>: Cast _BITSTR_BITS to int in a ternary operator.

Summary

This fixes a -Wsign-compare error reported by GCC due to the two
results of the ternary operator having differing signedness.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Feb 1 2022, 1:08 AM

Herald added a subscriber: imp. · View Herald TranscriptFeb 1 2022, 1:08 AM

jhb requested review of this revision.Feb 1 2022, 1:08 AM

Harbormaster completed remote builds in B44208: Diff 102190.Feb 1 2022, 1:08 AM

rlibby accepted this revision.Feb 1 2022, 1:46 AM

This revision is now accepted and ready to land.Feb 1 2022, 1:46 AM

dougm accepted this revision.Feb 1 2022, 6:00 AM

Closed by commit rG8a67a1a9646e: <sys/bitstring.h>: Cast _BITSTR_BITS to int in a ternary operator. (authored by jhb). · Explain WhyFeb 1 2022, 5:45 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG8a67a1a9646e: <sys/bitstring.h>: Cast _BITSTR_BITS to int in a ternary operator..

dougm added a commit: rG897877ae644d: <sys/bitstring.h>: Cast _BITSTR_BITS to int in a ternary operator..Jul 11 2022, 6:09 AM

Revision Contents
Changeset List

Path

Size

sys/

sys/

2 lines

Diff 102225

sys/sys/bitstring.h

Loading...