Page MenuHomeFreeBSD
Differential D34113

pseudofs: Make the sbuf usable
AbandonedPublic
Actions

Authored by manu on Jan 31 2022, 1:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, May 9, 9:58 PM
Unknown Object (File)
Thu, May 7, 4:56 AM
Unknown Object (File)
Wed, May 6, 6:35 AM
Unknown Object (File)
Sun, May 3, 11:30 AM
Unknown Object (File)
Mon, Apr 27, 2:12 PM
Unknown Object (File)
Tue, Apr 21, 12:52 AM
Unknown Object (File)
Mar 31 2026, 7:21 AM
Unknown Object (File)
Feb 27 2026, 1:51 AM
View All 66 Files
Subscribers
des
imp

Details

Reviewers
des
Summary

Call sbuf_finish for pfs_write to underlying pseudofs can actually use
the buffer.

MFC after: 1 week
Sponsored by: Beckhoff Automation GmbH & Co. KG

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 44186
Build 41074: arc lint + arc unit

Event Timeline

manu created this revision.Jan 31 2022, 1:49 PM
Herald added a subscriber: imp. · View Herald TranscriptJan 31 2022, 1:49 PM
manu requested review of this revision.Jan 31 2022, 1:49 PM
Harbormaster completed remote builds in B44186: Diff 102155.Jan 31 2022, 1:49 PM
des added a subscriber: des.Jan 31 2022, 2:12 PM

This is incorrect. The fill function is expected to finish the buffer. See for instance procfs_doosrel() in sys/fs/procfs/procfs_orsel.c.

des added a reviewer: des.Jan 31 2022, 2:14 PM
manu abandoned this revision.Jan 31 2022, 2:21 PM
In D34113#771377, @des wrote:

This is incorrect. The fill function is expected to finish the buffer. See for instance procfs_doosrel() in sys/fs/procfs/procfs_orsel.c.

Indeed, I've missed that.
So no need for this and I've added the sbuf_finish in D34114

Revision Contents
Changeset List

PathSize
sys/
fs/
pseudofs/
1 line

Diff 102155

View Options

sys/fs/pseudofs/pseudofs_vnops.c

Loading...