Apply the module ldscript correctly on a shared ko
Needs ReviewPublic
Actions

Authored by andrew on Jan 17 2022, 5:14 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Sep 29, 6:05 AM

	Unknown Object (File)
	Tue, Sep 22, 9:40 PM

	Unknown Object (File)
	Tue, Sep 15, 12:09 PM

	Unknown Object (File)
	Tue, Sep 15, 8:34 AM

	Unknown Object (File)
	Fri, Sep 11, 6:13 PM

	Unknown Object (File)
	Fri, Sep 11, 4:26 AM

	Unknown Object (File)
	Fri, Sep 11, 2:14 AM

	Unknown Object (File)
	Tue, Sep 8, 10:04 AM

View All Files

Subscribers

None

Details

Reviewers

kib
markj
imp

Summary

For kernel modules built as a shared object we link all the object
files together, then run ld again with the final link flags.

Previously we would apply the linker script to the former ld command
however the second linker command may undo these changes as it is
lacking access to the script. Fix this by moving the linker script to
the latter ld command when building a shared kernel object.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 43955
Build 40843: arc lint + arc unit

Event Timeline

andrew requested review of this revision.Jan 17 2022, 5:14 PM

andrew created this revision.

Harbormaster completed remote builds in B43955: Diff 101546.Jan 17 2022, 5:14 PM

kib added inline comments.Jan 17 2022, 7:00 PM

sys/conf/kmod.mk
244	Why this variable is needed?
sys/conf/ldscript.kmod.i386
31	Could you please explain the reason for this addition? Perhaps this should be done in the comment.