Page MenuHomeFreeBSD
Differential D33907

databases/influxdb: Improve syslog logging title
ClosedPublic
Actions

Authored by driesm on Jan 16 2022, 9:55 AM.
Tags
None
Referenced Files
F115475458: D33907.diff
Thu, Apr 24, 6:18 AM
Unknown Object (File)
Sun, Apr 20, 3:48 PM
Unknown Object (File)
Sun, Apr 20, 5:52 AM
Unknown Object (File)
Mar 15 2025, 5:50 PM
Unknown Object (File)
Mar 15 2025, 11:09 AM
Unknown Object (File)
Feb 21 2025, 10:08 AM
Unknown Object (File)
Feb 20 2025, 10:33 PM
Unknown Object (File)
Jan 10 2025, 7:01 AM
View All Files
Subscribers
mat

Details

Reviewers
0mp
philip
Commits
R11:dc765dc71a5b: databases/influxdb: Improve syslog logging title
Summary
databases/influxdb: Improve syslog logging title

While here also remove trailing spaces.

 Approved by:		tbd (mentor)
 Pull Request:		https://github.com/freebsd/freebsd-ports/pull/121
 Differential Revision:	https://reviews.freebsd.org/D33907

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

driesm created this revision.Jan 16 2022, 9:55 AM
Herald added a subscriber: mat. · View Herald TranscriptJan 16 2022, 9:55 AM
driesm requested review of this revision.Jan 16 2022, 9:55 AM
Harbormaster completed remote builds in B43937: Diff 101498.Jan 16 2022, 9:55 AM
driesm edited the summary of this revision. (Show Details)Jan 16 2022, 9:56 AM
driesm added reviewers: 0mp, philip.
driesm added a comment.EditedJan 17 2022, 1:28 PM

As explained in the PR, this changes the log entry from:

Jan 13 02:08:13 icarus daemon[43241]: ts=2022-01-13T10:08:13.768315Z lvl=info msg="InfluxDB starting" log_id=0Z0jOen0000 version=1.8.9 branch=unknown commit=unknown

To

Jan 13 02:09:10 icarus influxd[43292]: ts=2022-01-13T10:09:10.424810Z lvl=info msg="InfluxDB starting" log_id=0Z0jS760000 version=1.8.9 branch=unknown commit=unknown

0mp accepted this revision.Jan 25 2022, 12:38 AM
In D33907#766946, @driesm wrote:

As explained in the PR, this changes the log entry from:

Jan 13 02:08:13 icarus daemon[43241]: ts=2022-01-13T10:08:13.768315Z lvl=info msg="InfluxDB starting" log_id=0Z0jOen0000 version=1.8.9 branch=unknown commit=unknown

To

Jan 13 02:09:10 icarus influxd[43292]: ts=2022-01-13T10:09:10.424810Z lvl=info msg="InfluxDB starting" log_id=0Z0jS760000 version=1.8.9 branch=unknown commit=unknown

I'd include it in the commit message.

LGTM otherwise!

This revision is now accepted and ready to land.Jan 25 2022, 12:38 AM
Closed by commit R11:dc765dc71a5b: databases/influxdb: Improve syslog logging title (authored by Jeremy Chadwick <jdc@koitsu.org>, committed by driesm). · Explain WhyJan 25 2022, 7:38 PM
This revision was automatically updated to reflect the committed changes.
driesm added a commit: R11:dc765dc71a5b: databases/influxdb: Improve syslog logging title.

Revision Contents
Changeset List

PathSize
databases/
influxdb/
1 line
files/
14 lines

Diff 101913

View Options

databases/influxdb/Makefile

PORTNAME= influxdb PORTNAME= influxdb
DISTVERSIONPREFIX= v DISTVERSIONPREFIX= v
DISTVERSION= 1.8.10 DISTVERSION= 1.8.10
PORTREVISION= 1
CATEGORIES= databases net-mgmt CATEGORIES= databases net-mgmt
MAINTAINER= driesm@FreeBSD.org MAINTAINER= driesm@FreeBSD.org
COMMENT= Open-source distributed time series database COMMENT= Open-source distributed time series database
LICENSE= MIT LICENSE= MIT
LICENSE_FILE= ${WRKSRC}/LICENSE LICENSE_FILE= ${WRKSRC}/LICENSE
▲ Show 20 Lines • Show All 69 Lines • Show Last 20 Lines
View Options

databases/influxdb/files/influxd.in

Show All 37 Lines
: ${influxd_conf:="%%PREFIX%%/etc/${name}.conf"} : ${influxd_conf:="%%PREFIX%%/etc/${name}.conf"}
: ${influxd_options:="${influxd_flags} -config=${influxd_conf}"} : ${influxd_options:="${influxd_flags} -config=${influxd_conf}"}
# daemon # daemon
influxd_pidfile="%%INFLUXD_PIDDIR%%${name}.pid" influxd_pidfile="%%INFLUXD_PIDDIR%%${name}.pid"
procname="%%PREFIX%%/bin/${name}" procname="%%PREFIX%%/bin/${name}"
command=/usr/sbin/daemon command=/usr/sbin/daemon
start_precmd="influxd_precmd" start_precmd="influxd_precmd"
start_cmd="influxd_startcmd_%%INFLUXD_LOGCMD%%" start_cmd="influxd_startcmd_%%INFLUXD_LOGCMD%%"
influxd_precmd() influxd_precmd()
{ {
install -d -o ${influxd_user} %%INFLUXD_PIDDIR%% install -d -o ${influxd_user} %%INFLUXD_PIDDIR%%
} }
influxd_startcmd_daemon() influxd_startcmd_daemon()
{ {
echo "Starting ${name}." echo "Starting ${name}."
/usr/sbin/daemon -c -p ${influxd_pidfile} -S -s ${influxd_priority} -l ${influxd_facility} \ /usr/sbin/daemon -c -p ${influxd_pidfile} -S -s ${influxd_priority} -l ${influxd_facility} -T ${name} \
-u ${influxd_user} ${procname} ${influxd_options} -u ${influxd_user} ${procname} ${influxd_options}
} }
influxd_startcmd_logger() influxd_startcmd_logger()
{ {
echo "Starting ${name}." echo "Starting ${name}."
/usr/sbin/daemon -c -p ${influxd_pidfile} -u ${influxd_user} /bin/sh -c "${procname} ${influxd_options} 2>&1 \ /usr/sbin/daemon -c -p ${influxd_pidfile} -u ${influxd_user} /bin/sh -c "${procname} ${influxd_options} 2>&1 \
| /usr/bin/logger -t ${name} -p ${influxd_facility}.${influxd_priority}" | /usr/bin/logger -t ${name} -p ${influxd_facility}.${influxd_priority}"
} }
run_rc_command "$1" run_rc_command "$1"