Page MenuHomeFreeBSD

xen/netfront: deal with mbuf data crossing a page boundary
ClosedPublic

Authored by royger on Jan 13 2022, 3:37 PM.
Tags
None
Referenced Files
F111032383: D33876.diff
Wed, Feb 26, 11:35 AM
Unknown Object (File)
Tue, Feb 25, 4:09 AM
Unknown Object (File)
Sun, Feb 9, 5:59 PM
Unknown Object (File)
Tue, Feb 4, 7:34 PM
Unknown Object (File)
Tue, Feb 4, 2:12 AM
Unknown Object (File)
Jan 21 2025, 12:38 PM
Unknown Object (File)
Jan 17 2025, 5:15 PM
Unknown Object (File)
Jan 17 2025, 5:15 PM

Details

Summary

There's been a report recently of mbufs with data that crosses a page
boundary. It seems those mbufs are generated by the iSCSI target
system:

https://lists.xenproject.org/archives/html/xen-devel/2021-12/msg01581.html

In order to handle those mbufs correctly on netfront use the bus_dma
interface and explicitly request that segments must not cross a page
boundary. No other requirements are necessary, so it's expected that
bus_dma won't need to bounce the data and hence it shouldn't
introduce a too big performance penalty.

Using bus_dma requires some changes to netfront, mainly in order to
accommodate for the fact that now ring slots no longer have a 1:1
match with mbufs, as a single mbuf can use two ring slots if the data
buffer crosses a page boundary. Store the first packet of the mbuf
chain in every ring slot that's used, and use a mbuf tag in order to
store the bus_dma related structures and a refcount to keep track of
the pending slots before the mbuf chain can be freed.

Reported by: G.R.
Tested by: G.R.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 43900
Build 40788: arc lint + arc unit