Page MenuHomeFreeBSD
Differential D33798

LinuxKPI: add hex2bin()
ClosedPublic
Actions

Authored by bz on Jan 9 2022, 1:10 AM.
Tags
None
Referenced Files
F132333326: D33798.id.diff
Wed, Oct 15, 11:58 PM
F132333325: D33798.id101167.diff
Wed, Oct 15, 11:58 PM
F132333319: D33798.id101149.diff
Wed, Oct 15, 11:58 PM
F132333316: D33798.id101165.diff
Wed, Oct 15, 11:58 PM
Unknown Object (File)
Wed, Oct 15, 1:28 PM
Unknown Object (File)
Mon, Oct 13, 3:15 AM
Unknown Object (File)
Mon, Oct 6, 6:00 AM
Unknown Object (File)
Thu, Sep 25, 10:06 AM
View All 89 Files
Subscribers
emaste
• hselasky
imp

Details

Reviewers
• hselasky
Group Reviewers
linuxkpi
Commits
rGf88fcc52d888: LinuxKPI: add hex2bin()
rGdeb9bfbd5bce: LinuxKPI: add hex2bin()
Summary

Add a hex2bin() implementation needed by a driver's debugfs code.

MFC after: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bz created this revision.Jan 9 2022, 1:10 AM
Herald added subscribers: emaste, imp. · View Herald TranscriptJan 9 2022, 1:10 AM
bz requested review of this revision.Jan 9 2022, 1:10 AM
Harbormaster completed remote builds in B43792: Diff 101149.Jan 9 2022, 1:10 AM
bz added a comment.Jan 9 2022, 1:11 AM

I couldn't find any in libkern to my surprise. Let me know if we do have something more native.

• hselasky added a subscriber: • hselasky.Jan 9 2022, 9:18 AM
• hselasky added inline comments.
sys/compat/linuxkpi/common/include/linux/kernel.h
652

Char is not always signed?? Use int8_t ?

• hselasky added inline comments.Jan 9 2022, 10:27 AM
sys/compat/linuxkpi/common/include/linux/kernel.h
652

Functions that return error codes should use "int" type.

How do you know EINVAL fits into char?

bz updated this revision to Diff 101165.Jan 9 2022, 1:55 PM

Use int instead of char as requested though I'd hope we never change EINVAL.

Harbormaster completed remote builds in B43798: Diff 101165.Jan 9 2022, 1:55 PM
• hselasky accepted this revision.Jan 9 2022, 1:58 PM
This revision is now accepted and ready to land.Jan 9 2022, 1:58 PM
Closed by commit rGdeb9bfbd5bce: LinuxKPI: add hex2bin() (authored by bz). · Explain WhyJan 9 2022, 2:38 PM
This revision was automatically updated to reflect the committed changes.
bz added a commit: rGdeb9bfbd5bce: LinuxKPI: add hex2bin().
bz added a commit: rGf88fcc52d888: LinuxKPI: add hex2bin().Jan 16 2022, 11:21 PM

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
include/
linux/
31 lines

Diff 101167

View Options

sys/compat/linuxkpi/common/include/linux/kernel.h

Loading...