iscsi: Abort fewer data-out tasks on a terminating session.
ClosedPublic
Actions

Authored by jhb on Jan 4 2022, 10:42 PM.

Details

Reviewers

Group Reviewers

Commits

rG6a435d581fe2: iscsi: Abort fewer data-out tasks on a terminating session.
rGa3af69fa81d2: iscsi: Abort fewer data-out tasks on a terminating session.

Summary

Only abort tasks queued for datamove after
cfiscsi_sesssion_terminate_tasks has posted its internal
CTL_TASK_I_T_NEXUS_RESET task.

Reported by: Jithesh Arakkan @ Chelsio
Fixes: 0cd6e85e242b iscsi: Abort data-out tasks queued on a terminating session.
Sponsored by: Chelsio Communications

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Jan 4 2022, 10:42 PM

Herald added a reviewer: cam. · View Herald TranscriptJan 4 2022, 10:42 PM

Herald added a subscriber: imp. · View Herald Transcript

jhb requested review of this revision.Jan 4 2022, 10:42 PM

Harbormaster completed remote builds in B43711: Diff 100949.Jan 4 2022, 10:42 PM

I'm still waiting for Chelsio's QA to test this solution.

sys/cam/ctl/ctl_frontend_iscsi.c
2792	We may not need this warning, but for testing purposes at least I want to see if this case fires during testing.

mav accepted this revision.Jan 4 2022, 10:54 PM

This revision is now accepted and ready to land.Jan 4 2022, 10:54 PM

Closed by commit rGa3af69fa81d2: iscsi: Abort fewer data-out tasks on a terminating session. (authored by jhb). · Explain WhyJan 18 2022, 5:30 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGa3af69fa81d2: iscsi: Abort fewer data-out tasks on a terminating session..

jhb added a commit: rG6a435d581fe2: iscsi: Abort fewer data-out tasks on a terminating session..Apr 29 2022, 11:13 PM

Revision Contents
Changeset List

Path

Size

sys/

cam/

ctl/

ctl_frontend_iscsi.h

1 line

ctl_frontend_iscsi.c

7 lines

Diff 101588

View Options

sys/cam/ctl/ctl_frontend_iscsi.h