Page MenuHomeFreeBSD

Change page alignment behavior of boundary==0 in vm_reserv_reclaim_contig
ClosedPublic

Authored by dougm on Dec 25 2021, 10:06 PM.

Details

Reviewers
alc
markj
madpilot
Summary

Evidently, I misunderstood what "boundary==0" means. I thought it would be more like "boundary==1", when it fact it is more like "boundary==0x10000000000000".

Test Plan

Ask for help from Guido Falsi.

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

dougm created this revision.

Assume that if I'm wrong about boundary, I'm similarly wrong about alignment.

Catch another boundary == 0 problem.

dougm added a subscriber: pho.

Remove the alignment change. I think boundary is the only problem.

I've tested Diff 100574 and I am unable to reproduce the issue with that applied.

Without this patch Virtualbox virtual machines would report out of memory errors easily, just launching two or tree machines, and closing and launching the same machine a few times caused the issue to appear, now I've tested multiple machines, some using half the host RAM, running simultaneously and closing reopening them multiple times wothout issues. So from my POV this patch works fine.

This revision is now accepted and ready to land.Dec 26 2021, 9:33 AM