Differential D33596

ipfilter Ansification: Convert ipfilter userland function declarations from K&R to ANSI
Needs ReviewPublic
Actions

Authored by cy on Dec 20 2021, 10:41 PM.

Tags

None

Referenced Files

	F139885201: D33596.id.diff
	Wed, Dec 17, 2:34 PM

	Unknown Object (File)
	Sun, Nov 23, 12:46 AM

	Unknown Object (File)
	Sat, Nov 22, 8:51 PM

	Unknown Object (File)
	Sat, Nov 22, 7:22 PM

	Unknown Object (File)
	Sat, Nov 22, 7:21 PM

	Unknown Object (File)
	Sat, Nov 22, 7:16 PM

	Unknown Object (File)
	Oct 31 2025, 3:42 AM

	Unknown Object (File)
	Oct 29 2025, 11:48 PM

View All 22 Files

Subscribers

Details

Reviewers

Group Reviewers

Summary

Convert ipfilter userland function declarations from K&R to ANSI. This syncs our function declarations with NetBSD hg commit 75edcd7552a0 (apply our changes). Though not copied from NetBSD, this change was partially inspired by NetBSD's work and inspired by style(9).

Test Plan

Currently running here.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

cy created this revision.Dec 20 2021, 10:41 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 20 2021, 10:41 PM

cy requested review of this revision.Dec 20 2021, 10:41 PM

A copy can be found on github (https://github.com/cschuber/freebsd-ipf-ansi).

Revision Contents
Changeset List

Path

Size

sbin/

ipf/

common/

112 lines

54 lines

ipf/

55 lines

71 lines

ipfs/

41 lines

ipfstat/

143 lines

ipftest/

55 lines

16 lines

iplang/

14 lines

212 lines

ipmon/

109 lines

40 lines

ipnat/

53 lines

64 lines

ippool/

61 lines

24 lines

ipscan/

43 lines

ipsend/

6 lines

3 lines

232 lines

39 lines

5 lines

17 lines

10 lines

5 lines

48 lines

13 lines

10 lines

8 lines

8 lines

21 lines

3 lines

libipf/

7 lines

3 lines

3 lines

assigndefined.c

4 lines

5 lines

5 lines

5 lines

4 lines

4 lines

4 lines

4 lines

12 lines

3 lines

5 lines

5 lines

4 lines

3 lines

6 lines

5 lines

4 lines

3 lines

6 lines

5 lines

6 lines

4 lines

4 lines

7 lines

10 lines

5 lines

13 lines

17 lines

26 lines

36 lines

8 lines

16 lines

5 lines

5 lines

5 lines

load_dstlistnode.c

7 lines

5 lines

load_hashnode.c

8 lines

4 lines

load_poolnode.c

8 lines

4 lines

3 lines

18 lines

5 lines

nat_setgroupmap.c

4 lines

5 lines

6 lines

5 lines

5 lines

8 lines

4 lines

4 lines

parsewhoisline.c

5 lines

6 lines

4 lines

6 lines

printactiveaddr.c

5 lines

printactivenat.c

5 lines

6 lines

4 lines

4 lines

printdstl_live.c

8 lines

9 lines

printdstlistdata.c

4 lines

printdstlistnode.c

7 lines

printdstlistpolicy.c

3 lines

printfieldhdr.c

3 lines

4 lines

printfraginfo.c

4 lines

8 lines

printhash_live.c

7 lines

printhashdata.c

4 lines

printhashnode.c

8 lines

4 lines

4 lines

printhostmask.c

4 lines

4 lines

4 lines

15 lines

3 lines

3 lines

4 lines

4 lines

4 lines

6 lines

printnatfield.c

4 lines

4 lines

4 lines

4 lines

8 lines

printpool_live.c

8 lines

printpooldata.c

4 lines

printpoolfield.c

5 lines

printpoolnode.c

5 lines

4 lines

5 lines

6 lines

printstatefields.c

4 lines

printtcpflags.c

3 lines

3 lines

3 lines

3 lines

4 lines

remove_hashnode.c

6 lines

4 lines

remove_poolnode.c

7 lines

2 lines

32 lines

10 lines

19 lines

7 lines

10 lines

40 lines

37 lines

5 lines

3 lines

6 lines

12 lines

3 lines

share/

examples/

ipfilter/

l4check/

60 lines

Diff 100379

sbin/ipf/common/ipf_y.y

Loading...

sbin/ipf/common/lexer.c

Loading...

sbin/ipf/ipf/ipf.c

Loading...

sbin/ipf/ipf/ipfcomp.c

Loading...

sbin/ipf/ipfs/ipfs.c

Loading...

sbin/ipf/ipfstat/ipfstat.c

Loading...

sbin/ipf/ipftest/ipftest.c

Loading...

sbin/ipf/ipftest/md5.c

Loading...

sbin/ipf/iplang/iplang_l.l

Loading...

sbin/ipf/iplang/iplang_y.y

Loading...

sbin/ipf/ipmon/ipmon.c

Loading...

sbin/ipf/ipmon/ipmon_y.y

Loading...

sbin/ipf/ipnat/ipnat.c

Loading...

sbin/ipf/ipnat/ipnat_y.y

Loading...

sbin/ipf/ippool/ippool.c

Loading...

sbin/ipf/ippool/ippool_y.y

Loading...

sbin/ipf/ipscan/ipscan_y.y

Loading...

sbin/ipf/ipsend/44arp.c

Loading...

sbin/ipf/ipsend/arp.c

Loading...

sbin/ipf/ipsend/dlcommon.c

Loading...

sbin/ipf/ipsend/ip.c

Loading...

sbin/ipf/ipsend/ipresend.c

Loading...

sbin/ipf/ipsend/ipsend.c

Loading...

sbin/ipf/ipsend/ipsopt.c

Loading...

sbin/ipf/ipsend/iptest.c

Loading...

sbin/ipf/ipsend/iptests.c

Loading...

sbin/ipf/ipsend/resend.c

Loading...

sbin/ipf/ipsend/sbpf.c

Loading...

sbin/ipf/ipsend/sdlpi.c

Loading...

sbin/ipf/ipsend/snit.c

Loading...

sbin/ipf/ipsend/sock.c

Loading...

sbin/ipf/ipsend/sockraw.c

Loading...

sbin/ipf/libipf/addipopt.c

Loading...

sbin/ipf/libipf/alist_free.c

Loading...

sbin/ipf/libipf/allocmbt.c

Loading...

sbin/ipf/libipf/assigndefined.c

Loading...

sbin/ipf/libipf/bcopywrap.c

Loading...

sbin/ipf/libipf/binprint.c

Loading...

sbin/ipf/libipf/buildopts.c

Loading...

sbin/ipf/libipf/checkrev.c

Loading...

sbin/ipf/libipf/count4bits.c

Loading...

sbin/ipf/libipf/count6bits.c

Loading...

sbin/ipf/libipf/dupmbt.c

Loading...

sbin/ipf/libipf/facpri.c

Loading...

sbin/ipf/libipf/familyname.c

Loading...

sbin/ipf/libipf/fill6bits.c

Loading...

sbin/ipf/libipf/findword.c

Loading...

sbin/ipf/libipf/freembt.c

Loading...

sbin/ipf/libipf/ftov.c

Loading...

sbin/ipf/libipf/gethost.c

Loading...

sbin/ipf/libipf/geticmptype.c

Loading...

sbin/ipf/libipf/getifname.c

Loading...

sbin/ipf/libipf/getnattype.c

Loading...

sbin/ipf/libipf/getport.c

Loading...

sbin/ipf/libipf/getportproto.c

Loading...

sbin/ipf/libipf/getproto.c

Loading...

sbin/ipf/libipf/getsumd.c

Loading...

sbin/ipf/libipf/icmptypename.c

Loading...

sbin/ipf/libipf/inet_addr.c

Loading...

sbin/ipf/libipf/interror.c

Loading...

sbin/ipf/libipf/ipf_dotuning.c

Loading...

sbin/ipf/libipf/ipf_perror.c

Loading...

sbin/ipf/libipf/ipft_hx.c

Loading...

sbin/ipf/libipf/ipft_pc.c

Loading...

sbin/ipf/libipf/ipft_tx.c

Loading...

sbin/ipf/libipf/ipoptsec.c

Loading...

sbin/ipf/libipf/kmem.c

Loading...

sbin/ipf/libipf/kmemcpywrap.c

Loading...

sbin/ipf/libipf/kvatoname.c

Loading...

sbin/ipf/libipf/load_dstlist.c

Loading...

sbin/ipf/libipf/load_dstlistnode.c

Loading...

sbin/ipf/libipf/load_hash.c

Loading...

sbin/ipf/libipf/load_hashnode.c

Loading...

sbin/ipf/libipf/load_pool.c

Loading...

sbin/ipf/libipf/load_poolnode.c

Loading...

sbin/ipf/libipf/mb_hexdump.c

Loading...

sbin/ipf/libipf/msgdsize.c

Loading...

sbin/ipf/libipf/mutex_emul.c

Loading...

sbin/ipf/libipf/nametokva.c

Loading...

sbin/ipf/libipf/nat_setgroupmap.c

Loading...

sbin/ipf/libipf/ntomask.c

Loading...

sbin/ipf/libipf/optname.c

Loading...

sbin/ipf/libipf/optprint.c

Loading...

sbin/ipf/libipf/optprintv6.c

Loading...

sbin/ipf/libipf/optvalue.c

Loading...

sbin/ipf/libipf/parsefields.c

Loading...

sbin/ipf/libipf/parseipfexpr.c

Loading...

sbin/ipf/libipf/parsewhoisline.c

Loading...

sbin/ipf/libipf/poolio.c

Loading...

sbin/ipf/libipf/prependmbt.c

Loading...

sbin/ipf/libipf/print_toif.c

Loading...

sbin/ipf/libipf/printactiveaddr.c

Loading...

sbin/ipf/libipf/printactivenat.c

Loading...

sbin/ipf/libipf/printaddr.c

Loading...

sbin/ipf/libipf/printaps.c

Loading...

sbin/ipf/libipf/printbuf.c

Loading...

sbin/ipf/libipf/printdstl_live.c

Loading...

sbin/ipf/libipf/printdstlist.c

Loading...

sbin/ipf/libipf/printdstlistdata.c

Loading...

sbin/ipf/libipf/printdstlistnode.c

Loading...

sbin/ipf/libipf/printdstlistpolicy.c

Loading...

sbin/ipf/libipf/printfieldhdr.c

Loading...

sbin/ipf/libipf/printfr.c

Loading...

sbin/ipf/libipf/printfraginfo.c

Loading...

sbin/ipf/libipf/printhash.c

Loading...

sbin/ipf/libipf/printhash_live.c

Loading...

sbin/ipf/libipf/printhashdata.c

Loading...

sbin/ipf/libipf/printhashnode.c

Loading...

sbin/ipf/libipf/printhost.c

Loading...

sbin/ipf/libipf/printhostmap.c

Loading...

sbin/ipf/libipf/printhostmask.c

Loading...

sbin/ipf/libipf/printifname.c

Loading...

sbin/ipf/libipf/printip.c

Loading...

sbin/ipf/libipf/printipfexpr.c

Loading...

sbin/ipf/libipf/printiphdr.c

Loading...

sbin/ipf/libipf/printlog.c

Loading...

sbin/ipf/libipf/printlookup.c

Loading...

sbin/ipf/libipf/printmask.c

Loading...

sbin/ipf/libipf/printnat.c

Loading...

sbin/ipf/libipf/printnataddr.c

Loading...

sbin/ipf/libipf/printnatfield.c

Loading...

sbin/ipf/libipf/printnatside.c

Loading...

sbin/ipf/libipf/printpacket.c

Loading...

sbin/ipf/libipf/printpacket6.c

Loading...

sbin/ipf/libipf/printpool.c

Loading...

sbin/ipf/libipf/printpool_live.c

Loading...

sbin/ipf/libipf/printpooldata.c

Loading...

sbin/ipf/libipf/printpoolfield.c

Loading...

sbin/ipf/libipf/printpoolnode.c

Loading...

sbin/ipf/libipf/printportcmp.c

Loading...

sbin/ipf/libipf/printproto.c

Loading...

sbin/ipf/libipf/printsbuf.c

Loading...

sbin/ipf/libipf/printstatefields.c

Loading...

sbin/ipf/libipf/printtcpflags.c

Loading...

sbin/ipf/libipf/printtqtable.c

Loading...

sbin/ipf/libipf/printtunable.c

Loading...

sbin/ipf/libipf/printunit.c

Loading...

sbin/ipf/libipf/remove_hash.c

Loading...

sbin/ipf/libipf/remove_hashnode.c

Loading...

sbin/ipf/libipf/remove_pool.c

Loading...

sbin/ipf/libipf/remove_poolnode.c

Loading...

sbin/ipf/libipf/resetlexer.c

Loading...

sbin/ipf/libipf/rwlock_emul.c

Loading...

sbin/ipf/libipf/save_execute.c

Loading...

sbin/ipf/libipf/save_file.c

Loading...

sbin/ipf/libipf/save_nothing.c

Loading...

sbin/ipf/libipf/save_syslog.c

Loading...

sbin/ipf/libipf/save_v1trap.c

Loading...

sbin/ipf/libipf/save_v2trap.c

Loading...

sbin/ipf/libipf/tcp_flags.c

Loading...

sbin/ipf/libipf/tcpflags.c

Loading...

sbin/ipf/libipf/v6optvalue.c

Loading...

sbin/ipf/libipf/var.c

Loading...

sbin/ipf/libipf/vtof.c

Loading...

share/examples/ipfilter/l4check/l4check.c

Loading...