net-mgmt/netdata: General improvements

[driesm]

Summary

net-mgmt/netdata: General improvements

- Simplify post-patch logic
- Pet portclippy and portfmt

 Approved by:		tbd (mentor)
 Differential Revision:	https://reviews.freebsd.org/D33590

Test Plan

Testport looks good, I tested both CLOUD on and off and verified patch is only applied when CLOUD is off. post-patch is always applied like it should.

[diizzy]

net-mgmt/netdata/Makefile

33

No, read 5.4.3 in Porters Handbook

62

This a matter of preference, it uses more than one tab simple to line up with OPTIONS_

86–87

Since we're only using it once it doesn't make much sense to create a variable

[driesm]

Thanks for the review Daniel!

net-mgmt/netdata/Makefile

33

Hmm, I just did but I don't see what you are referring to within that section?

62

Agreed, this is just portfmt output, can be left as is, no harm done.

86–87

Twice :), once at DISTFILES and once at post-patch-CLOUD-off.

[diizzy]

net-mgmt/netdata/Makefile

33

If the distribution file comes from a specific commit or tag on GitHub for which there is no officially released file - There is one (release tarball/archive)

86–87

Right, I'm personally not too fond of the idea of referencing variables before they're defined in ports Makefile(s) but that's a personal preference. I would personally try to parse ALLFILES (or similar) instead but it's not a hard no from my side.

[driesm]

drop USE_GITHUB

[0mp]

If those are all clean-ups, then there is no need to bump PORTREVISION.

[driesm]

drop revision bump

[driesm]

In D33590#760215, @0mp wrote:

If those are all clean-ups, then there is no need to bump PORTREVISION.

No functional change intended. :)