Page MenuHomeFreeBSD

Re-introduce baselibs qa check
ClosedPublic

Authored by antoine on Aug 10 2015, 3:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
May 25 2026, 5:42 PM
Unknown Object (File)
May 23 2026, 6:13 PM
Unknown Object (File)
May 17 2026, 8:12 PM
Unknown Object (File)
May 8 2026, 9:17 PM
Unknown Object (File)
May 1 2026, 11:31 PM
Unknown Object (File)
Apr 26 2026, 5:56 PM
Unknown Object (File)
Apr 25 2026, 10:36 PM
Unknown Object (File)
Apr 24 2026, 3:09 PM
Subscribers

Details

Summary

Re-introduce baselibs qa check

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

antoine retitled this revision from to Re-introduce baselibs qa check.
antoine updated this object.
antoine edited the test plan for this revision. (Show Details)
antoine edited edge metadata.

Eliminate a grep

bapt added a reviewer: bapt.
bapt added a subscriber: bapt.

I wanted to test the path to be independent from version, but I bet this is better like this.

This revision is now accepted and ready to land.Aug 10 2015, 3:45 PM
This revision was automatically updated to reflect the committed changes.

Maybe you could have used readelf to get the list of the libs to check, and ldd to get their path ?

The switch to readelf introduced a bug.
I think it does not make sense to reopen this after it was committed so many years ago.
See inline comment.
Fix we need to add on top https://github.com/freebsd/freebsd-ports/pull/567
and the bug report https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=296889

head/Mk/Scripts/qa.sh
114

With hindsight 11 years later,
this change broke qa.sh
because the error behavior differs between ldd -a and readelf -d:

ldd -a will process each file given irrespective if you pass some scripts,
readelf -d will abort when looking at the first non-ELF object,
and the 2>/dev/null discards readelf's error message.

Fix in https://github.com/freebsd/freebsd-ports/pull/567
Problem report in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=296889