libdwarf: Fix error handling in _dwarf_elf_init()
ClosedPublic
Actions

Authored by markj on Dec 13 2021, 8:27 PM.

Tags

None

Referenced Files

	F165281658: D33420.id99965.diff
	Fri, Aug 7, 9:39 AM

	F165265581: D33420.id99957.diff
	Fri, Aug 7, 7:00 AM

	Unknown Object (File)
	Thu, Aug 6, 7:26 AM

	Unknown Object (File)
	Wed, Aug 5, 8:04 AM

	Unknown Object (File)
	Sun, Aug 2, 10:16 AM

	Unknown Object (File)
	Wed, Jul 22, 5:08 PM

	Unknown Object (File)
	Sun, Jul 19, 8:49 PM

	Unknown Object (File)
	Sun, Jul 19, 8:49 PM

View All Files

Subscribers

imp

Details

Reviewers

emaste

Commits

rGc983ec6428ec: libdwarf: Fix error handling in _dwarf_elf_init()

Summary

We were not setting "ret" before jumping to the error path, so the
function returned success even when it had failed.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Dec 13 2021, 8:27 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 13 2021, 8:27 PM

markj requested review of this revision.Dec 13 2021, 8:27 PM

Harbormaster completed remote builds in B43324: Diff 99957.Dec 13 2021, 8:27 PM

emaste accepted this revision.Dec 13 2021, 8:28 PM

This revision is now accepted and ready to land.Dec 13 2021, 8:28 PM

Closed by commit rGc983ec6428ec: libdwarf: Fix error handling in _dwarf_elf_init() (authored by markj). · Explain WhyDec 13 2021, 11:51 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGc983ec6428ec: libdwarf: Fix error handling in _dwarf_elf_init().

Revision Contents
Changeset List

Path

Size

contrib/

elftoolchain/

libdwarf/

libdwarf_elf_init.c

8 lines

Diff 99965

View Options

contrib/elftoolchain/libdwarf/libdwarf_elf_init.c

libdwarf: Fix error handling in _dwarf_elf_init()ClosedPublicActions