Page MenuHomeFreeBSD

textproc/gojq: New port
ClosedPublic

Authored by driesm on Nov 30 2021, 9:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 23, 6:36 PM
Unknown Object (File)
Fri, Oct 18, 9:15 AM
Unknown Object (File)
Wed, Oct 16, 1:23 AM
Unknown Object (File)
Tue, Oct 15, 8:19 AM
Unknown Object (File)
Sun, Oct 13, 8:44 AM
Unknown Object (File)
Fri, Oct 11, 9:44 AM
Unknown Object (File)
Tue, Oct 8, 10:40 PM
Unknown Object (File)
Tue, Oct 8, 11:54 AM
Subscribers

Details

Summary
textproc/gojq: New port

Pure Go implementation of jq.

 PR:			259884
 Approved by:		tbd (mentor)
 Differential Revision:	https://reviews.freebsd.org/D33204
Test Plan

Testport looks good. portfmt, portclippy, portlint are all happy.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 43076
Build 39964: arc lint + arc unit

Event Timeline

driesm added reviewers: 0mp, philip.

Approved by: philip (mentor)

(provided the package cleans up share/zsh/site-functions)

textproc/gojq/Makefile
7

I thought Nork-san was a committer?

19

Do you need to add an @dir share/zsh/site-functions to pkg-plist to clean this up? Or is pkg smart enough?

This revision is now accepted and ready to land.Dec 1 2021, 2:23 AM
philip requested changes to this revision.Dec 1 2021, 2:25 AM

Just spotted the mis-ordered textproc/Makefile :)

textproc/Makefile
240

Oh. I think this is not in alphabetical order.

This revision now requires changes to proceed.Dec 1 2021, 2:25 AM
driesm added inline comments.
textproc/Makefile
240

Haha, derp. Nothing happened here.
Macro lgtm:

textproc/gojq/Makefile
7

Ah yes indeed, I have found this: https://reviews.freebsd.org/R11:83fc7a83ad8bf9f24eceafa5a7ce18a09b992238
Maybe possible to revive his bit, if he's up for it ;).

19

I have checked ports-mgmt/pkg, shells/zsh-completions, and they all lack the @dir, the directory will be present and populated wth _pkg as a minimum if you want any working port installed. Sometimes people also install there own completions in there. Does @dir only remove it when its empty? Then it wouldn't hurt either way.

driesm marked an inline comment as done.
textproc/gojq/Makefile
19

Given it a further thought, it wouldn't hurt either way but it would always be a no-op given pkg has already something installed in there. (if it only deletes the dir if its empty with @dir)

Thanks for checking that. I always forget when pkg is smart enough about empty directories.
This looks good to me! Feel free to commit.

This revision is now accepted and ready to land.Dec 1 2021, 8:20 AM
This revision was automatically updated to reflect the committed changes.