textproc/gojq: New port Pure Go implementation of jq. PR: 259884 Approved by: tbd (mentor) Differential Revision: https://reviews.freebsd.org/D33204
Details
- Reviewers
0mp philip - Commits
- R11:8b46ce03f521: textproc/gojq: New port
Testport looks good. portfmt, portclippy, portlint are all happy.
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 43076 Build 39964: arc lint + arc unit
Event Timeline
Just spotted the mis-ordered textproc/Makefile :)
textproc/Makefile | ||
---|---|---|
240 | Oh. I think this is not in alphabetical order. |
textproc/Makefile | ||
---|---|---|
240 | Haha, derp. Nothing happened here. | |
textproc/gojq/Makefile | ||
7 | Ah yes indeed, I have found this: https://reviews.freebsd.org/R11:83fc7a83ad8bf9f24eceafa5a7ce18a09b992238 | |
19 | I have checked ports-mgmt/pkg, shells/zsh-completions, and they all lack the @dir, the directory will be present and populated wth _pkg as a minimum if you want any working port installed. Sometimes people also install there own completions in there. Does @dir only remove it when its empty? Then it wouldn't hurt either way. |
textproc/gojq/Makefile | ||
---|---|---|
19 | Given it a further thought, it wouldn't hurt either way but it would always be a no-op given pkg has already something installed in there. (if it only deletes the dir if its empty with @dir) |
Thanks for checking that. I always forget when pkg is smart enough about empty directories.
This looks good to me! Feel free to commit.