Page MenuHomeFreeBSD
Differential D33142

mixer(3): Remove useless comments
AbandonedPublic
Actions

Authored by christos on Nov 28 2021, 2:27 AM.
Tags
Referenced Files
Unknown Object (File)
Thu, Apr 18, 12:03 AM
Unknown Object (File)
Wed, Apr 3, 2:37 AM
Unknown Object (File)
Dec 23 2023, 12:42 PM
Unknown Object (File)
Dec 21 2023, 6:11 AM
Unknown Object (File)
Sep 5 2023, 12:27 PM
Unknown Object (File)
May 28 2023, 11:20 AM
Unknown Object (File)
Feb 25 2023, 2:43 PM
Unknown Object (File)
Feb 17 2023, 7:41 AM
View All 11 Files
Subscribers
None

Details

Reviewers
• hselasky
imp

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

christos requested review of this revision.Nov 28 2021, 2:27 AM
christos created this revision.
• hselasky added a comment.Nov 28 2021, 9:33 AM

I think each function should have a description:

This function does ...

Can you explain a bit more the motivation here?

--HPS

christos added a comment.EditedNov 28 2021, 1:23 PM

Can you explain a bit more the motivation here?

I believe some functions are pretty self-explanatory either
because of their name or because of their implementation, so some
of the comments serve no real purpose in my opinion.

• hselasky added a comment.Nov 28 2021, 1:58 PM

Comments sometimes help verify that the code has been implemented correctly.

christos added a comment.Nov 28 2021, 4:32 PM
In D33142#749020, @hselasky wrote:

Comments sometimes help verify that the code has been implemented correctly.

Fair enough, should I abort this revision then?

christos abandoned this revision.Nov 29 2021, 2:13 PM

Revision Contents
Changeset List

PathSize
lib/
libmixer/
39 lines

Diff 99089

View Options

lib/libmixer/mixer.c

Loading...