security/py-vpn-slice: Add NO_ARCH Approved by: tbd (mentor), portmgr (blanket) Differential Revision: https://reviews.freebsd.org/D33105
Details
- Reviewers
philip 0mp - Commits
- R11:de338b6a083b: security/py-vpn-slice: Add NO_ARCH
Diff Detail
- Repository
- R11 FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Just a note: sometimes people don't bump portrevision when adding NO_ARCH (e.g., https://github.com/freebsd/freebsd-ports/commit/8918d79d4efdaf2ed1ac659d51e77913f439da7f). The reason is that this is not an important change from the user perspective and perhaps it's not necessary to trigger a package rebuild. However, according to PHB, PORTREVISION must be bumped whenever the contents of the final package change AFAIR. When in doubt, ask fellow committers. As always, if you are unsure about some part of the change, note it in the commit message.
Interesting, would you commit it with or without PORTREVISION bump? Now that you say it, the package is already built for all arches. Adding NO_ARCH and bumping kinda goes against the philosophy of sparing CPU cycles on the cluster, which is ultimately the goal of NO_ARCH. So I'm leaning towards leaving PORTREVISION out in the end. What do you think? I guess bumping wouldn't hurt either given PHB advice.
^^ So to be clear: you would skip bumping PORTREVISION? Right? (like sunpoet's commit)