Variables must be quoted if they contain non-alphanumeric characters.
MFC after: 7 days
Differential D33092
os-release: Quote variables as documented in the manual 0mp on Nov 23 2021, 10:29 AM. Authored by Tags None Referenced Files
Subscribers None
Details
Diff Detail
Event TimelineComment Actions From the standard:
None of these are possible with the freebsd-version -u output. A number of other things break if people use 'custom' release names with spaces in them... Comment Actions I absolutely agree that it does not matter from sh(1) perspective, but the manual page says that non-alphanumeric values must be quoted. Maybe there is software out there that relies on that. This is rather unlikely. Nevertheless, being consistent with out own documentation is definitely worth the effort. Ubuntu for example quotes those values as documented. Comment Actions Thank you for the review! I committed the patch in https://cgit.freebsd.org/src/commit/?id=169e06fa7852810f4ced2cce7a3c14ca9443bf39. |