ffs: fix newly introduced LOR between mntfs vnode lock and topology lock
ClosedPublic
Actions

Authored by kib on Nov 16 2021, 5:35 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Apr 14, 10:59 AM

	Unknown Object (File)
	Mon, Apr 13, 8:36 PM

	Unknown Object (File)
	Mon, Apr 13, 8:18 PM

	Unknown Object (File)
	Fri, Apr 10, 1:27 AM

	Unknown Object (File)
	Mon, Mar 30, 2:50 PM

	Unknown Object (File)
	Mar 4 2026, 3:36 PM

	Unknown Object (File)
	Feb 26 2026, 4:03 AM

	Unknown Object (File)
	Feb 9 2026, 3:30 PM

View All 98 Files

Subscribers

imp

pho

Details

Reviewers

markj

Commits

rGc34a5148e8f2: ffs: fix newly introduced LOR between mntfs vnode lock and topology lock

Summary

The mntfs vnode lock should be before topology, as established in
ffs_mountfs().  Extend the locked region in ffs_unmount().

Reported by:    markj

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Nov 16 2021, 5:35 PM

Herald added a subscriber: imp. · View Herald TranscriptNov 16 2021, 5:35 PM

kib requested review of this revision.Nov 16 2021, 5:35 PM

Thanks

This revision is now accepted and ready to land.Nov 16 2021, 5:38 PM

Closed by commit rGc34a5148e8f2: ffs: fix newly introduced LOR between mntfs vnode lock and topology lock (authored by kib). · Explain WhyNov 16 2021, 6:02 PM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rGc34a5148e8f2: ffs: fix newly introduced LOR between mntfs vnode lock and topology lock.

Revision Contents
Changeset List

Path

Size

sys/

geom/

geom_vfs.c

2 lines

ufs/

ffs/

ffs_vfsops.c

2 lines

Diff 98587

View Options

sys/geom/geom_vfs.c