ktls: Use ATF_REQUIRE instead of assert() for validating TLS header lengths.
ClosedPublic
Actions

Authored by jhb on Nov 15 2021, 10:01 PM.

Details

Reviewers

Commits

rGb2d704ea8820: ktls: Use ATF_REQUIRE instead of assert() for validating TLS header lengths.
rGd71830cdf0df: ktls: Use ATF_REQUIRE instead of assert() for validating TLS header lengths.

Summary

The TLS header length field is set by the kernel, so if it is
incorrect that is an indication of a kernel bug, not an internal error
in the tests.

Prompted by: markj
Sponsored by: Netflix

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 42797
Build 39685: arc lint + arc unit

Event Timeline

jhb created this revision.Nov 15 2021, 10:01 PM

Herald added a subscriber: imp. · View Herald TranscriptNov 15 2021, 10:01 PM

jhb requested review of this revision.Nov 15 2021, 10:01 PM

Harbormaster completed remote builds in B42797: Diff 98549.Nov 15 2021, 10:01 PM

jhb added a child revision: D33004: ktls tests: Check the return values of close()..Nov 15 2021, 10:01 PM

markj accepted this revision.Nov 15 2021, 10:04 PM

This revision is now accepted and ready to land.Nov 15 2021, 10:04 PM

Closed by commit rGd71830cdf0df: ktls: Use ATF_REQUIRE instead of assert() for validating TLS header lengths. (authored by jhb). · Explain WhyNov 16 2021, 5:57 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGd71830cdf0df: ktls: Use ATF_REQUIRE instead of assert() for validating TLS header lengths..

jhb added a commit: rGb2d704ea8820: ktls: Use ATF_REQUIRE instead of assert() for validating TLS header lengths..Nov 23 2021, 11:14 PM

Revision Contents
Changeset List

Path

Size

tests/

sys/

kern/

ktls_test.c

6 lines

Diff 98549

View Options

tests/sys/kern/ktls_test.c

ktls: Use ATF_REQUIRE instead of assert() for validating TLS header lengths.ClosedPublicActions