Page MenuHomeFreeBSD
Differential D32972

linker_kldload_busy(): allow recursion
ClosedPublic
Actions

Authored by kib on Nov 12 2021, 7:51 PM.
Tags
None
Referenced Files
F166461441: D32972.diff
Thu, Aug 13, 5:22 PM
Unknown Object (File)
Wed, Aug 12, 4:13 PM
Unknown Object (File)
Wed, Aug 12, 1:39 PM
Unknown Object (File)
Wed, Aug 12, 3:00 AM
Unknown Object (File)
Tue, Aug 11, 8:14 AM
Unknown Object (File)
Mon, Aug 10, 9:45 AM
Unknown Object (File)
Mon, Aug 10, 9:45 AM
Unknown Object (File)
Sun, Aug 9, 1:49 PM
View All Files
Subscribers
imp

Details

Reviewers
• hselasky
markj
Commits
rG4f924a786ae0: linker_kldload_busy(): allow recursion
Summary
Some drivers recursively loads modules by explicit calls to kldload
during initialization, which might occur during kldload.

PR:     259748

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib created this revision.Nov 12 2021, 7:51 PM
Herald added a subscriber: imp. · View Herald TranscriptNov 12 2021, 7:51 PM
kib requested review of this revision.Nov 12 2021, 7:51 PM
markj accepted this revision.Nov 12 2021, 8:20 PM

The change looks ok, but after re-reading D30456 I wonder if busying should be done in sys_kldload() and sys_kldunload() instead. If the kernel initiates an unload at the "wrong" time then it's a bug in the initiator.

This revision is now accepted and ready to land.Nov 12 2021, 8:20 PM
Closed by commit rG4f924a786ae0: linker_kldload_busy(): allow recursion (authored by kib). · Explain WhyNov 28 2021, 8:36 AM
This revision was automatically updated to reflect the committed changes.
kib added a commit: rG4f924a786ae0: linker_kldload_busy(): allow recursion.

Revision Contents
Changeset List

PathSize
sys/
kern/
22 lines

Diff 99097

View Options

sys/kern/kern_linker.c

Loading...