Complete steps 5 and 9 for new committers (driesm)
ClosedPublic
Actions

Authored by driesm on Nov 8 2021, 1:21 PM.

Details

Reviewers

philip
0mp

Commits

rGecf58c066cb7: Complete steps 5 and 9 for new committers (driesm)

Summary

This should include the necessary changes to the src tree.

Commit message:

Reviewed by: tbd (mentor)
Approved by: tbd (mentor)
Differential Revision: https://reviews.freebsd.org/D32890

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

driesm created this revision.Nov 8 2021, 1:21 PM

Herald added a subscriber: imp. · View Herald TranscriptNov 8 2021, 1:21 PM

driesm requested review of this revision.Nov 8 2021, 1:21 PM

Harbormaster completed remote builds in B42657: Diff 98192.Nov 8 2021, 1:21 PM

driesm retitled this revision from Complete steps 5 & 9 for new committers (driesm) to Complete steps 5 and 9 for new committers (driesm).Nov 8 2021, 1:26 PM

driesm edited the summary of this revision. (Show Details)

Looks good to me!

This revision is now accepted and ready to land.Nov 8 2021, 3:11 PM

BTW, I guess I understand correctly that the final commit message is going to be along the lines of:

Complete steps 5 and 9 for new committers (driesm)

Reviewed by: tbd (mentor)
Approved by: tbd (mentor)
Differential Revision: https://reviews.freebsd.org/D32890

right?

That is correct :). That was indeed not so clear, I'll make sure to add the title under "commit message" for future revisions.

Closed by commit rGecf58c066cb7: Complete steps 5 and 9 for new committers (driesm) (authored by driesm). · Explain WhyNov 8 2021, 4:22 PM

This revision was automatically updated to reflect the committed changes.

driesm added a commit: rGecf58c066cb7: Complete steps 5 and 9 for new committers (driesm).