Fix bad arithmetic in umtx_key_get() to compute object offset.
ClosedPublic
Actions

Authored by ed on Aug 3 2015, 9:29 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Dec 9, 2:53 PM

	Unknown Object (File)
	Thu, Nov 28, 7:31 PM

	Unknown Object (File)
	Thu, Nov 28, 7:30 PM

	Unknown Object (File)
	Mon, Nov 25, 6:31 AM

	Unknown Object (File)
	Sep 25 2024, 9:06 AM

	Unknown Object (File)
	Sep 24 2024, 8:06 PM

	Unknown Object (File)
	Sep 24 2024, 5:40 AM

	Unknown Object (File)
	Sep 24 2024, 1:11 AM

View All 55 Files

Subscribers

imp

Details

Reviewers

kib
jhb

Commits

rS286277: Fix bad arithmetic in umtx_key_get() to compute object offset.

Summary

It looks like umtx_key_get() has the addition and subtraction the wrong
way around, meaning that it fails to match in certain cases. This causes
the cloudlibc unit tests to deadlock in certain cases.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ed updated this revision to Diff 7623.Aug 3 2015, 9:29 PM

ed retitled this revision from to Fix bad arithmetic in umtx_key_get() to compute object offset..

ed updated this object.

ed edited the test plan for this revision. (Show Details)

ed added reviewers: kib, jhb.

Herald added a subscriber: imp. · View Herald TranscriptAug 3 2015, 9:29 PM

kib accepted this revision.Aug 4 2015, 4:41 AM

kib edited edge metadata.

This revision is now accepted and ready to land.Aug 4 2015, 4:41 AM

Closed by commit rS286277: Fix bad arithmetic in umtx_key_get() to compute object offset. (authored by ed). · Explain WhyAug 4 2015, 6:01 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

kern/

kern_umtx.c

4 lines

Diff 7638

View Options

Fix bad arithmetic in umtx_key_get() to compute object offset.ClosedPublicActions