Page MenuHomeFreeBSD

LinuxKPI: add bcd.h
ClosedPublic

Authored by bz on Oct 25 2021, 6:20 PM.
Tags
None
Referenced Files
F131829099: D32647.id97422.diff
Sat, Oct 11, 12:41 PM
Unknown Object (File)
Wed, Oct 1, 1:06 AM
Unknown Object (File)
Mon, Sep 22, 1:24 PM
Unknown Object (File)
Sun, Sep 21, 9:56 PM
Unknown Object (File)
Sun, Sep 21, 9:51 PM
Unknown Object (File)
Sat, Sep 20, 9:41 PM
Unknown Object (File)
Sat, Sep 20, 6:49 PM
Unknown Object (File)
Sat, Sep 20, 2:52 PM

Details

Reviewers
hselasky
Group Reviewers
linuxkpi
Commits
rG548ada00e54a: LinuxKPI: add bcd.h
Summary

Add bcd2bin() as linuxkpi_bcd2bin(). Libkern does provide a bcd2bin()
which cannot be used leaving us with a conflict (see comment in file).
Fortunately this is only seen in one driver so far and it seems easier
to drop this in and change a single line in the driver than to add this
inline in the driver.

MFC after: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bz requested review of this revision.Oct 25 2021, 6:20 PM
hselasky added inline comments.
sys/compat/linuxkpi/common/include/linux/bcd.h
51

Use function macros here. (Style)

Use function macros in #if 0 block for better style.

sys/compat/linuxkpi/common/include/linux/bcd.h
42

spelling: dirvers

and try to spell drivers more like it should be written.

This revision is now accepted and ready to land.Oct 25 2021, 6:33 PM
This revision was automatically updated to reflect the committed changes.
bz marked 2 inline comments as done.