Differential D32647

LinuxKPI: add bcd.h
ClosedPublic
Actions

Authored by bz on Oct 25 2021, 6:20 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Sep 11, 4:11 PM

	Unknown Object (File)
	Thu, Sep 10, 1:15 PM

	Unknown Object (File)
	Sun, Sep 6, 2:07 PM

	Unknown Object (File)
	Sun, Sep 6, 11:46 AM

	Unknown Object (File)
	Sun, Sep 6, 3:35 AM

	Unknown Object (File)
	Sun, Sep 6, 1:33 AM

	Unknown Object (File)
	Sat, Sep 5, 11:33 AM

	Unknown Object (File)
	Sat, Sep 5, 11:26 AM

Subscribers

Details

Reviewers

Group Reviewers

Commits

rG548ada00e54a: LinuxKPI: add bcd.h

Summary

Add bcd2bin() as linuxkpi_bcd2bin(). Libkern does provide a bcd2bin()
which cannot be used leaving us with a conflict (see comment in file).
Fortunately this is only seen in one driver so far and it seems easier
to drop this in and change a single line in the driver than to add this
inline in the driver.

MFC after: 3 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bz created this revision.Oct 25 2021, 6:20 PM

Herald added subscribers: emaste, imp. · View Herald TranscriptOct 25 2021, 6:20 PM

bz requested review of this revision.Oct 25 2021, 6:20 PM

Harbormaster completed remote builds in B42350: Diff 97422.Oct 25 2021, 6:20 PM

• hselasky added a subscriber: • hselasky.Oct 25 2021, 6:27 PM

• hselasky added inline comments.

sys/compat/linuxkpi/common/include/linux/bcd.h
51	Use function macros here. (Style)

Use function macros in #if 0 block for better style.

Harbormaster completed remote builds in B42351: Diff 97423.Oct 25 2021, 6:31 PM

• hselasky added inline comments.Oct 25 2021, 6:31 PM

sys/compat/linuxkpi/common/include/linux/bcd.h
42	spelling: dirvers

and try to spell drivers more like it should be written.

Harbormaster completed remote builds in B42352: Diff 97424.Oct 25 2021, 6:32 PM

Looks good.

This revision is now accepted and ready to land.Oct 25 2021, 6:33 PM

Closed by commit rG548ada00e54a: LinuxKPI: add bcd.h (authored by bz). · Explain WhyOct 25 2021, 8:23 PM

This revision was automatically updated to reflect the committed changes.

bz marked 2 inline comments as done.

bz added a commit: rG548ada00e54a: LinuxKPI: add bcd.h.

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

include/

linux/

53 lines

Diff 97433

sys/compat/linuxkpi/common/include/linux/bcd.h

Loading...