linux: Make PTRACE_GETREGSET return proper buffer size
ClosedPublic
Actions

Authored by trasz on Oct 23 2021, 7:32 PM.

Details

Reviewers

Group Reviewers

Commits

rGbb726462cbea: linux: Make PTRACE_GETREGSET return proper buffer size
rGf939dccfd770: linux: Make PTRACE_GETREGSET return proper buffer size

Summary

This fixes Chrome warning:

[1022/152319.328632:ERROR:ptracer.cc(476)] Unexpected registers size 0 != 216, 68

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

trasz created this revision.Oct 23 2021, 7:32 PM

Herald added subscribers: emaste, imp. · View Herald TranscriptOct 23 2021, 7:32 PM

trasz requested review of this revision.Oct 23 2021, 7:32 PM

Harbormaster completed remote builds in B42323: Diff 97339.Oct 23 2021, 7:32 PM

trasz added a reviewer: Linux Emulation.Oct 23 2021, 7:32 PM

Was this just an incorrect understanding in R10:faf2fa21d70b1e625cb7af032e6608e631931486?

trasz retitled this revision from linux: Make PTRACE_GETREGSET return proper buffer size to linux: Make PTRACE_GETREGS return proper buffer size.Oct 29 2021, 12:24 PM

In D32616#738055, @emaste wrote:

Was this just an incorrect understanding in R10:faf2fa21d70b1e625cb7af032e6608e631931486?

That one's for PTRACE_GETREGSET, while this revision changes PTRACE_GETREGS - although it incorrectly claimed to do PTRACE_GETREGSET; fixed now :-)

I think it was just a misunderstanding in d82de05480f; strace(1) seems to accept the previous, truncated, struct somehow.

emaste accepted this revision.Oct 29 2021, 1:34 PM

This revision is now accepted and ready to land.Oct 29 2021, 1:34 PM

Sigh, no, you were right. My comment is for https://reviews.freebsd.org/D32601, not for this one here.

trasz retitled this revision from linux: Make PTRACE_GETREGS return proper buffer size to linux: Make PTRACE_GETREGSET return proper buffer size.Oct 29 2021, 2:31 PM

Closed by commit rGf939dccfd770: linux: Make PTRACE_GETREGSET return proper buffer size (authored by trasz). · Explain WhyOct 29 2021, 3:04 PM

This revision was automatically updated to reflect the committed changes.

trasz added a commit: rGf939dccfd770: linux: Make PTRACE_GETREGSET return proper buffer size.

trasz added a commit: rGbb726462cbea: linux: Make PTRACE_GETREGSET return proper buffer size.Feb 21 2022, 1:51 PM