CloudABI has two separate kernel modules: cloudabi and cloudabi64. The
first module contains all the pointer size independent code, whereas
cloudabi64 contains the actual 64-bits specific system calls and the ELF
loader.
Details
Details
- Reviewers
wblock - Group Reviewers
manpages - Commits
- rS286205: Add a manual page for the cloudabi and cloudabi64 kernel modules.
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| share/man/man4/cloudabi.4 | ||
|---|---|---|
| 34 ↗ | (On Diff #7541) | Please avoid the informal "you" and "your". Here, it can just be "the" instead of "your". It is redundant to use "the following" for something that is immediately following. This sentence can be rearranged to avoid the pause: Support for 64-bit CloudABI executables can be compiled into the kernel by adding |
| 51 ↗ | (On Diff #7541) | Use the serial comma after "test": easier to test, and hardened against security exploits. |
| 65 ↗ | (On Diff #7541) | This is a bit vague. What does "assuming" mean here? Is the module assuming all pointers are 64-bit? Is it used in the sense of "converting"? Or does this mean that only 64-bit pointers are handled? Please be specific. |
| 66 ↗ | (On Diff #7541) | "can" implies that it is not required. Maybe: It also provides the image activator that loads a 64-bit ELF |
| 67 ↗ | (On Diff #7541) | That is the correct use of possessive "its", but used twice, it is hard to tell what it refers to. Does the image activator load the executable into the image activator's space, or the executable's space? Possibly this can be simplified, like: The image activator loads and starts a 64-bit ELF executable. |
| 75 ↗ | (On Diff #7541) | What does "exists" mean here? Maybe "works", or maybe "is only available for"? |
| 77 ↗ | (On Diff #7541) | "can be obtained by installing" is simpler as just "is available in" |
Comment Actions
Thanks for the quick response!
| share/man/man4/cloudabi.4 | ||
|---|---|---|
| 34 ↗ | (On Diff #7541) | Though I agree this can be improved, I actually used this construct because it is present in many other man pages: $ zgrep -r 'place the following lines in your' /usr/share/man/man4 | wc -l 282 That said, I don't care too strongly about this. What's your thought? |
| 65 ↗ | (On Diff #7541) | I've extended this. Does this look better? |
| share/man/man4/cloudabi.4 | ||
|---|---|---|
| 35 ↗ | (On Diff #7551) | That it has been used many times before has also come up before. :) I don't think that's really a very strong argument. In one way, it's an argument against improving. Nor do I think that people are constructing kernel configs by grepping man pages. If they are, we really need a much more strict notation. Anyway, we are not forced to use the old wording. When there is a chance to eliminate redundancy and pauses, I'll take it. The line I suggested above is still what I prefer. |
| 40 ↗ | (On Diff #7551) | As above, "the following" is redundant, and the sentence is halted in a couple of places by commas. Consider the alternative: CloudABI support can also be loaded at boot time from |
| 66 ↗ | (On Diff #7551) | Yes, much better! |