Page MenuHomeFreeBSD
Differential D32502

kldstat(8): Fix indentation
ClosedPublic
Actions

Authored by christos on Oct 14 2021, 11:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 2, 12:59 AM
Unknown Object (File)
Wed, Oct 29, 11:38 PM
Unknown Object (File)
Mon, Oct 27, 1:33 AM
Unknown Object (File)
Sun, Oct 26, 12:32 PM
Unknown Object (File)
Sat, Oct 25, 3:55 PM
Unknown Object (File)
Sat, Oct 25, 3:20 PM
Unknown Object (File)
Sat, Oct 25, 3:13 PM
Unknown Object (File)
Sat, Oct 25, 3:05 PM
View All Files
Subscribers
None

Details

Reviewers
• hselasky
imp
Commits
rG5620ab6c8e3f: kldstat(8): Fix indentation, whitespace to tabs.
rG337c814316ef: kldstat(8): Fix indentation, whitespace to tabs.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

christos requested review of this revision.Oct 14 2021, 11:21 PM
christos created this revision.
• hselasky added a comment.Oct 15 2021, 9:23 AM

You should separate bare whitespace changes and code changes into two different commits.

Also were the whitespace changes scripted? I have a script{F30350946} which does exactly that. Run that _twice_ first! Then see what changes are left.

christos added a comment.Oct 15 2021, 11:40 AM
In D32502#733300, @hselasky wrote:

You should separate bare whitespace changes and code changes into two different commits.

Alright.

Also were the whitespace changes scripted? I have a script{F30350946} which does exactly that. Run that _twice_ first! Then see what changes are left.

No, the changes were made by hand. :-)

christos updated this revision to Diff 96896.Oct 15 2021, 11:51 AM

Indentation only.

christos updated this revision to Diff 96897.EditedOct 15 2021, 11:54 AM

Minor fix in indentation.

I'll upload the code changes after this one is committed.

christos retitled this revision from kldstat(8): Fix style to kldstat(8): Fix indentation.Oct 15 2021, 12:25 PM
christos mentioned this in D32506: kldstat(8): style(9) fix.
christos added a child revision: D32506: kldstat(8): style(9) fix.
christos updated this revision to Diff 96903.Oct 15 2021, 1:00 PM

Include whole file in diff.

• hselasky accepted this revision.Nov 9 2021, 9:00 PM

Let's see how it goes. Looks good.

This revision is now accepted and ready to land.Nov 9 2021, 9:00 PM
Closed by commit rG337c814316ef: kldstat(8): Fix indentation, whitespace to tabs. (authored by • hselasky). · Explain WhyNov 9 2021, 9:13 PM
This revision was automatically updated to reflect the committed changes.
• hselasky added a commit: rG337c814316ef: kldstat(8): Fix indentation, whitespace to tabs..
• hselasky added a commit: rG5620ab6c8e3f: kldstat(8): Fix indentation, whitespace to tabs..Jan 7 2022, 1:31 PM

Revision Contents
Changeset List

PathSize
sbin/
kldstat/
261 lines

Diff 98273

View Options

sbin/kldstat/kldstat.c

Loading...