Page MenuHomeFreeBSD

Roll WITHOUT_ELFTOOLCHAIN_TOOLS into WITHOUT_TOOLCHAIN
ClosedPublic

Authored by emaste on Jul 29 2015, 9:28 PM.

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

emaste retitled this revision from to Roll WITHOUT_ELFTOOLCHAIN_TOOLS into WITHOUT_TOOLCHAIN.
emaste updated this object.
emaste edited the test plan for this revision. (Show Details)

UPDATING entry omitted to avoid merge conflicts before D3238 is committed.

Makefile.inc1
1485

These are for the build tools stage, and should probably not be controlled by MK_TOOLCHAIN. They'd need the equivalent of MK_TOOLCHAIN_BOOTSTRAP, but probably best to just leave them on unconditionally.

gnu/usr.bin/binutils/Makefile
15–17

gnu/usr.bin/binutils/ is only built when MK_TOOLCHAIN == yes so no need to test it here.

emaste added reviewers: imp, brooks.

Rebase and clean up

emaste added inline comments.
Makefile.inc1
1485

I'm not certain what we should be testing here and below. We want the equivalent of MK_BINUTILS_BOOTSTRAP for ELF Tool Chain. MK_BINUTILS_BOOTSTRAP isn't documented, but is enabled unless turned off by setting WITHOUT_CROSS_COMPILER or if set broken by the arch.

brooks edited edge metadata.
brooks added inline comments.
Makefile.inc1
1485

I might just use MK_BINUTILS_BOOTSTRAP since is effectively internal and I think expresses what we want (don't built the non-compiler part of the toolchain). lld may complicate that a bit since it's llvm based and thus will come with clang not with elftoolchain or binutils.

This revision is now accepted and ready to land.Aug 12 2015, 8:29 PM
This revision was automatically updated to reflect the committed changes.
Makefile.inc1
1485

Oops -- see D3381. I committed with the change suggested here, but it's not correct because we force MK_BINUTILS_BOOTSTRAP off for arm64.